Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 194813002: Removing WebRTCAudioDeviceTest test suite (Closed)

Created:
6 years, 9 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 9 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, phoglund_chromium
Visibility:
Public.

Description

Removing the WebRTCAudioDeviceTest test suite. We have decided to remove this test since it seems to cost more than it saves. The scope is too wide, most tests are ad-hoc tests and several tests are manual. Also, it has resulted in a long list of reported issues which are platform dependent. BUG=238490, 268376, 269348, 247447, 238490, 318189, 167299, 131154, 155284, 247163, 103711, 148865, 331030 TEST=content_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256621

Patch Set 1 #

Patch Set 2 : More dependencies #

Patch Set 3 : xians@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1765 lines) Patch
M content/content_tests.gypi View 1 3 chunks +0 lines, -5 lines 0 comments Download
D content/renderer/media/webrtc_audio_device_unittest.cc View 1 chunk +0 lines, -987 lines 0 comments Download
D content/test/webrtc_audio_device_test.h View 1 chunk +0 lines, -212 lines 0 comments Download
D content/test/webrtc_audio_device_test.cc View 1 chunk +0 lines, -454 lines 0 comments Download
M tools/valgrind/gtest_exclude/content_unittests.gtest.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tools/valgrind/gtest_exclude/content_unittests.gtest_mac.txt View 1 2 chunks +0 lines, -9 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M tools/valgrind/tsan/suppressions.txt View 1 1 chunk +0 lines, -87 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
henrika (OOO until Aug 14)
Now, that's a long list of related bugs ;-) Please check.
6 years, 9 months ago (2014-03-11 11:19:26 UTC) #1
no longer working on chromium
On 2014/03/11 11:19:26, henrika wrote: > Now, that's a long list of related bugs ;-) ...
6 years, 9 months ago (2014-03-11 11:54:50 UTC) #2
henrika (OOO until Aug 14)
Verified that content_unittests builds and runs locally with the new dependencies. Waiting for OK from ...
6 years, 9 months ago (2014-03-11 12:12:45 UTC) #3
tommi (sloooow) - chröme
Just a heads up that I won't have time until the end of the day ...
6 years, 9 months ago (2014-03-11 12:27:21 UTC) #4
henrika (OOO until Aug 14)
Nop. We can land tomorrow.
6 years, 9 months ago (2014-03-11 12:39:37 UTC) #5
tommi (sloooow) - chröme
lgtm!!!
6 years, 9 months ago (2014-03-12 15:00:26 UTC) #6
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 9 months ago (2014-03-12 15:17:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/194813002/40001
6 years, 9 months ago (2014-03-12 15:18:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/194813002/40001
6 years, 9 months ago (2014-03-12 16:58:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/194813002/40001
6 years, 9 months ago (2014-03-12 19:15:55 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 20:14:10 UTC) #11
Message was sent while issue was closed.
Change committed as 256621

Powered by Google App Engine
This is Rietveld 408576698