Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1948123004: [Media, UI] Improve large icon in MediaNotification (Closed)

Created:
4 years, 7 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media, UI] Improve large icon in MediaNotification This CL sets a new minimal favicon size to be used as MediaNotification large icon. Also, this CL removes the media session image since they usually look bad on lockscreen. BUG=599937 Committed: https://crrev.com/b08510c91c582eec094f03a1230b6f12158019a8 Cr-Commit-Position: refs/heads/master@{#392047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 3 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Zhiqiang Zhang (Slow)
4 years, 7 months ago (2016-05-05 17:34:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948123004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948123004/1
4 years, 7 months ago (2016-05-05 17:35:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 19:07:00 UTC) #6
mlamouri (slow - plz ping)
lgtm
4 years, 7 months ago (2016-05-06 13:31:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948123004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948123004/1
4 years, 7 months ago (2016-05-06 13:44:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 13:47:33 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 13:49:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b08510c91c582eec094f03a1230b6f12158019a8
Cr-Commit-Position: refs/heads/master@{#392047}

Powered by Google App Engine
This is Rietveld 408576698