Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1948123003: Replace 'allowTypeParameters' with 'numTypeArguments'. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace 'allowTypeParameters' with 'numTypeArguments'. With the final goal to get rid of it because we will move to providing type arguments for all type parameters in order to implement the 'instantiate to bounds' feature. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a281a61d8275d24f022414095133aa0eb1a1222e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -33 lines) Patch
M pkg/analyzer/test/src/summary/summary_common.dart View 24 chunks +31 lines, -33 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 7 months ago (2016-05-05 17:09:55 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1948123003/diff/1/pkg/analyzer/test/src/summary/summary_common.dart File pkg/analyzer/test/src/summary/summary_common.dart (right): https://codereview.chromium.org/1948123003/diff/1/pkg/analyzer/test/src/summary/summary_common.dart#newcode576 pkg/analyzer/test/src/summary/summary_common.dart:576: * reached via the given prefix. If [allowTypeArguments] ...
4 years, 7 months ago (2016-05-05 17:25:01 UTC) #2
scheglov
4 years, 7 months ago (2016-05-05 17:52:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a281a61d8275d24f022414095133aa0eb1a1222e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698