Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1948113003: Upgrade Iterable and Iterator. (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+971 lines, -414 lines) Patch
M lib/runtime/dart_sdk.js View 36 chunks +498 lines, -233 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +0 lines, -1 line 0 comments Download
M tool/input_sdk/lib/core/iterable.dart View 4 chunks +408 lines, -105 lines 0 comments Download
M tool/input_sdk/lib/core/iterator.dart View 2 chunks +25 lines, -14 lines 0 comments Download
M tool/input_sdk/lib/core/string.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/internal/iterable.dart View 22 chunks +29 lines, -44 lines 0 comments Download
M tool/input_sdk/private/string_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/sdk_expected_errors.txt View 2 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years, 7 months ago (2016-05-05 03:19:13 UTC) #2
vsm
lgtm
4 years, 7 months ago (2016-05-05 03:22:17 UTC) #3
sra1
4 years, 7 months ago (2016-05-05 03:22:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e862bf8cafdbee7f1c3f95bcc790721150fad62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698