Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: pkg/analyzer/tool/summary/dump_inferred_types.dart

Issue 1948103002: Skip local functions when dumping inferred types. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/tool/summary/dump_inferred_types.dart
diff --git a/pkg/analyzer/tool/summary/dump_inferred_types.dart b/pkg/analyzer/tool/summary/dump_inferred_types.dart
index 8b38e73d824b9721acb9605abd8ac2fc00779fd3..5167b104a36f1b6546fe46ed846108365a0e9d88 100644
--- a/pkg/analyzer/tool/summary/dump_inferred_types.dart
+++ b/pkg/analyzer/tool/summary/dump_inferred_types.dart
@@ -63,6 +63,10 @@ class InferredTypeCollector {
properties.remove('initializer');
} else if (obj is UnlinkedExecutable) {
collectInferredType(obj.inferredReturnTypeSlot, path);
+ // As a temporary measure, prevent recursion into the executable's local
+ // variables and local functions, since AST-based type inference doesn't
+ // infer locals correctly yet. TODO(paulberry): fix if necessary.
+ properties.remove('localFunctions');
} else if (obj is UnlinkedParam) {
collectInferredType(obj.inferredTypeSlot, path);
// As a temporary measure, prevent recursion into the parameter's
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698