[Findit] Adding more try job error detection

appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 import json
 import time
 
 from common.waterfall import buildbucket_client
 from common.waterfall import try_job_error
@@ skipping 369 matching lines @@
         'message': 'Buildbucket reported an error.',
         'reason': MonitorTryJobPipeline.UNKNOWN
     }
 
     self.assertEqual(
         MonitorTryJobPipeline._GetError(build_response, None, False),
         (expected_error_dict, try_job_error.CI_REPORTED_ERROR))
 
   def testGetErrorInfraFailure(self):
     build_response = {
+        'result': 'FAILED',
+        'failure_reason': 'INFRA_FAILURE',
         'result_details_json': json.dumps({
             'properties': {
                 'report': {
                     'metadata': {
                         'infra_failure': True
                     }
                 }
             }
         })
     }
 
     expected_error_dict = {
         'message': 'Try job encountered an infra issue during execution.',
         'reason': MonitorTryJobPipeline.UNKNOWN
     }
 
     self.assertEqual(
         MonitorTryJobPipeline._GetError(build_response, None, False),
         (expected_error_dict, try_job_error.INFRA_FAILURE))
 
+  def testGetErrorUnexpectedBuildFailure(self):
+    build_response = {
+        'result': 'FAILED',
+        'failure_reason': 'BUILD_FAILURE',
+        'result_details_json': json.dumps({
+            'properties': {
+                'report': {
+                    'metadata': {
+                        'infra_failure': True
+                    }
+                }
+            }
+        })
+    }
+
+    expected_error_dict = {
+        'message': 'Compile failed unexpectedly.',
+        'reason': MonitorTryJobPipeline.UNKNOWN
+    }
+
+    self.assertEqual(
+        MonitorTryJobPipeline._GetError(build_response, None, False),
+        (expected_error_dict, try_job_error.INFRA_FAILURE))
+
+  def testGetErrorUnknownBuildbucketFailure(self):
+    build_response = {
+        'result': 'FAILED',
+        'failure_reason': 'SOME_FAILURE',
+        'result_details_json': json.dumps({
+            'properties': {
+                'report': {}
+            }
+        })
+    }
+
+    expected_error_dict = {
+        'message': 'SOME_FAILURE',
+        'reason': MonitorTryJobPipeline.UNKNOWN
+    }
+
+    self.assertEqual(
+        MonitorTryJobPipeline._GetError(build_response, None, False),
+        (expected_error_dict, try_job_error.UNKNOWN))
+
   def testGetErrorReportMissing(self):
     build_response = {
         'result_details_json': json.dumps({
             'properties': {}
         })
     }
 
     expected_error_dict = {
         'message': 'No result report was found.',
         'reason': MonitorTryJobPipeline.UNKNOWN
     }
 
     self.assertEqual(
         MonitorTryJobPipeline._GetError(build_response, None, False),
         (expected_error_dict, try_job_error.UNKNOWN))
+
+

[chanli, 2016/05/06 23:17:46]

nit: empty lines

[lijeffrey, 2016/05/07 00:12:45]

Done.