Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1948043002: S390: [Atomics] Make Atomics.store a builtin using TF (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [Atomics] Make Atomics.store a builtin using TF Port 81cb841170dab08e3e3bc0256e867f9de17873f5 R=binji@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4614 LOG=N Committed: https://crrev.com/a6d9f423270a9f0cf17d3fa37e86dc71988dfeed Cr-Commit-Position: refs/heads/master@{#36039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 7 months ago (2016-05-04 17:43:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948043002/1
4 years, 7 months ago (2016-05-04 17:44:54 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 18:15:41 UTC) #5
MTBrandyberry
lgtm
4 years, 7 months ago (2016-05-04 18:35:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948043002/1
4 years, 7 months ago (2016-05-04 18:37:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 18:39:04 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:40:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6d9f423270a9f0cf17d3fa37e86dc71988dfeed
Cr-Commit-Position: refs/heads/master@{#36039}

Powered by Google App Engine
This is Rietveld 408576698