Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1948033005: Rename MintingExample.template.apk to WebApk.template.apk (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
Xi Han, Yaron
CC:
Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename MintingExample.template.apk to WebApk.template.apk BUG=609488

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Messages

Total messages: 8 (5 generated)
pkotwicz
Xi can you please take a look?
4 years, 7 months ago (2016-05-05 21:39:21 UTC) #4
Yaron
lgtm https://codereview.chromium.org/1948033005/diff/40001/apk_minter/src/org/chromium/apkminter/APKMinting.java File apk_minter/src/org/chromium/apkminter/APKMinting.java (right): https://codereview.chromium.org/1948033005/diff/40001/apk_minter/src/org/chromium/apkminter/APKMinting.java#newcode53 apk_minter/src/org/chromium/apkminter/APKMinting.java:53: private static final String TEMPLATE_APK_NAME = "WebApk.template.apk"; Per ...
4 years, 7 months ago (2016-05-05 21:41:33 UTC) #6
pkotwicz
4 years, 7 months ago (2016-05-06 15:37:54 UTC) #7
After additional offline discussion we agreed to keep WebApk.template.apk

Powered by Google App Engine
This is Rietveld 408576698