Revert of 🐸 Check for 0-length files in ResourceExtractor

Revert of Check for 0-length files in ResourceExtractor (patchset #3 id:40001 of https://codereview.chromium.org/1920893003/ )

Reason for revert:
Possibly regressed memory usage on android (http://crbug.com/607598)

Speculative revert to see if vm_private_dirty_final_browser values go back down for android bots on the perf waterfall

Original issue's description:
> Check for 0-length files in ResourceExtractor
>
> Also moves from an on-disk version timestamp file to SharedPreferences
> (should be faster).
>
> BUG=606413
>
> Committed: https://crrev.com/b28607d4c72261657ea9e24ea9195bc23a472b3f
> Cr-Commit-Position: refs/heads/master@{#390068}

TBR=yfriedman@chromium.org,torne@chromium.org,wnwen@chromium.org,agrieve@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606413
Committed: https://crrev.com/a3f2dd5d896ca693224403ad072cfad70882174b
Cr-Commit-Position: refs/heads/master@{#393023}

[qyearsley, 2016-05-05 16:29:13]

Created Revert of 🐸 Check for 0-length files in ResourceExtractor

[commit-bot: I haz the power, 2016-05-05 16:29:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948033004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948033004/1

[agrieve, 2016-05-05 17:13:12]

Description was changed from

==========
Revert of 🐸 Check for 0-length files in ResourceExtractor (patchset #3 id:40001
of https://codereview.chromium.org/1920893003/ )

Reason for revert:
Possibly regressed memory usage on android (http://crbug.com/607598)

Speculative revert to see if vm_private_dirty_final_browser values go back down
for android bots on the perf waterfall

Original issue's description:
> Check for 0-length files in ResourceExtractor
> 
> Also moves from an on-disk version timestamp file to SharedPreferences
> (should be faster).
> 
> BUG=606413
> 
> Committed: https://crrev.com/b28607d4c72261657ea9e24ea9195bc23a472b3f
> Cr-Commit-Position: refs/heads/master@{#390068}

TBR=yfriedman@chromium.org,torne@chromium.org,wnwen@chromium.org,agrieve@chro...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606413
==========

to

==========
Revert of Check for 0-length files in ResourceExtractor (patchset #3 id:40001 of
https://codereview.chromium.org/1920893003/ )

Reason for revert:
Possibly regressed memory usage on android (http://crbug.com/607598)

Speculative revert to see if vm_private_dirty_final_browser values go back down
for android bots on the perf waterfall

Original issue's description:
> Check for 0-length files in ResourceExtractor
> 
> Also moves from an on-disk version timestamp file to SharedPreferences
> (should be faster).
> 
> BUG=606413
> 
> Committed: https://crrev.com/b28607d4c72261657ea9e24ea9195bc23a472b3f
> Cr-Commit-Position: refs/heads/master@{#390068}

TBR=yfriedman@chromium.org,torne@chromium.org,wnwen@chromium.org,agrieve@chro...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606413
==========

[commit-bot: I haz the power, 2016-05-05 20:16:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 20:16:07]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[qyearsley, 2016-05-10 22:35:20]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-10 22:36:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948033004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948033004/1

[commit-bot: I haz the power, 2016-05-10 22:38:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 22:38:39]

Dry run: Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qyearsley, 2016-05-11 17:59:13]

Hi agrieve@, is it still OK to try to speculatively revert this to see if the
possible perf regression recovers?

If so, can you check to see if this revert patch is correct? (It's not a
completely clean revert now)

[agrieve, 2016-05-11 18:00:23]

On 2016/05/11 17:59:13, qyearsley wrote:
> Hi agrieve@, is it still OK to try to speculatively revert this to see if the
> possible perf regression recovers?
> 
> If so, can you check to see if this revert patch is correct? (It's not a
> completely clean revert now)

lgtm - sorry didn't realize you didn't submit this.

[agrieve, 2016-05-11 18:04:58]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-05-11 18:05:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948033004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948033004/40001

[commit-bot: I haz the power, 2016-05-11 19:24:33]

Description was changed from

==========
Revert of Check for 0-length files in ResourceExtractor (patchset #3 id:40001 of
https://codereview.chromium.org/1920893003/ )

Reason for revert:
Possibly regressed memory usage on android (http://crbug.com/607598)

Speculative revert to see if vm_private_dirty_final_browser values go back down
for android bots on the perf waterfall

Original issue's description:
> Check for 0-length files in ResourceExtractor
> 
> Also moves from an on-disk version timestamp file to SharedPreferences
> (should be faster).
> 
> BUG=606413
> 
> Committed: https://crrev.com/b28607d4c72261657ea9e24ea9195bc23a472b3f
> Cr-Commit-Position: refs/heads/master@{#390068}

TBR=yfriedman@chromium.org,torne@chromium.org,wnwen@chromium.org,agrieve@chro...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606413
==========

to

==========
Revert of Check for 0-length files in ResourceExtractor (patchset #3 id:40001 of
https://codereview.chromium.org/1920893003/ )

Reason for revert:
Possibly regressed memory usage on android (http://crbug.com/607598)

Speculative revert to see if vm_private_dirty_final_browser values go back down
for android bots on the perf waterfall

Original issue's description:
> Check for 0-length files in ResourceExtractor
> 
> Also moves from an on-disk version timestamp file to SharedPreferences
> (should be faster).
> 
> BUG=606413
> 
> Committed: https://crrev.com/b28607d4c72261657ea9e24ea9195bc23a472b3f
> Cr-Commit-Position: refs/heads/master@{#390068}

TBR=yfriedman@chromium.org,torne@chromium.org,wnwen@chromium.org,agrieve@chro...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606413
==========

[commit-bot: I haz the power, 2016-05-11 19:24:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-11 19:29:17]

Description was changed from

==========
Revert of Check for 0-length files in ResourceExtractor (patchset #3 id:40001 of
https://codereview.chromium.org/1920893003/ )

Reason for revert:
Possibly regressed memory usage on android (http://crbug.com/607598)

Speculative revert to see if vm_private_dirty_final_browser values go back down
for android bots on the perf waterfall

Original issue's description:
> Check for 0-length files in ResourceExtractor
> 
> Also moves from an on-disk version timestamp file to SharedPreferences
> (should be faster).
> 
> BUG=606413
> 
> Committed: https://crrev.com/b28607d4c72261657ea9e24ea9195bc23a472b3f
> Cr-Commit-Position: refs/heads/master@{#390068}

TBR=yfriedman@chromium.org,torne@chromium.org,wnwen@chromium.org,agrieve@chro...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606413
==========

to

==========
Revert of Check for 0-length files in ResourceExtractor (patchset #3 id:40001 of
https://codereview.chromium.org/1920893003/ )

Reason for revert:
Possibly regressed memory usage on android (http://crbug.com/607598)

Speculative revert to see if vm_private_dirty_final_browser values go back down
for android bots on the perf waterfall

Original issue's description:
> Check for 0-length files in ResourceExtractor
>
> Also moves from an on-disk version timestamp file to SharedPreferences
> (should be faster).
>
> BUG=606413
>
> Committed: https://crrev.com/b28607d4c72261657ea9e24ea9195bc23a472b3f
> Cr-Commit-Position: refs/heads/master@{#390068}

TBR=yfriedman@chromium.org,torne@chromium.org,wnwen@chromium.org,agrieve@chro...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606413

Committed: https://crrev.com/a3f2dd5d896ca693224403ad072cfad70882174b
Cr-Commit-Position: refs/heads/master@{#393023}
==========

[commit-bot: I haz the power, 2016-05-11 19:29:18]

Patchset 2 (id:??) landed as
https://crrev.com/a3f2dd5d896ca693224403ad072cfad70882174b
Cr-Commit-Position: refs/heads/master@{#393023}

[agrieve, 2016-05-19 18:32:10]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1996663002/ by agrieve@chromium.org.

The reason for reverting is: Will update description once changed..