Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame.js

Issue 1948033003: Convert most geolocation layout tests to use a JS mock implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-disconnect
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame.js
diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame.js b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame.js
index de364a7b3c26d2c0a12061259c0fa619032f6d77..a0a1a88010fb759875f4b69ad2dc8d6f8f6bd217 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame.js
+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame.js
@@ -1,18 +1,16 @@
description("Tests that when a request is made on a Geolocation object and its Frame is disconnected before a callback is made, no callbacks are made.");
-if (!window.testRunner || !window.internals)
- debug('This test can not run without testRunner or internals');
+if (!window.testRunner || !window.mojo)
+ debug('This test can not run without testRunner or mojo');
-internals.setGeolocationClientMock(document);
-internals.setGeolocationPermission(document, true);
-internals.setGeolocationPosition(document, 51.478, -0.166, 100);
+var error;
+var iframe = document.createElement('iframe');
function onIframeLoaded() {
iframeGeolocation = iframe.contentWindow.navigator.geolocation;
iframe.src = 'data:text/html,This frame should be visible when the test completes';
}
-var error;
function onIframeUnloaded() {
iframeGeolocation.getCurrentPosition(function () {
testFailed('Success callback invoked unexpectedly');
@@ -27,8 +25,12 @@ function onIframeUnloaded() {
}, 100);
}
-var iframe = document.createElement('iframe');
-iframe.src = 'resources/disconnected-frame-inner.html';
-document.body.appendChild(iframe);
+geolocationServiceMock.then(mock => {
+ mock.setGeolocationPermission(true);
+ mock.setGeolocationPosition(51.478, -0.166, 100);
+
+ iframe.src = 'resources/disconnected-frame-inner.html';
+ document.body.appendChild(iframe);
+});
window.jsTestIsAsync = true;

Powered by Google App Engine
This is Rietveld 408576698