third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html - Issue 1948033003: Convert most geolocation layout tests to use a JS mock implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html

Issue 1948033003: Convert most geolocation layout tests to use a JS mock implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-disconnect

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/remove-remote-context-in-error-callback-crash-inner.html ('k') | third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/TEMPLATE.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html

index f1a2f6edae705e2d64428645ba30361201f951d9..8b9504a22190f1aa77b75490f200683ccd8a9841 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html

@@ -1,17 +1,20 @@

+<script src="../../../../resources/mojo-helpers.js"></script>

+<script src="geolocation-mock.js"></script>

var mockLatitude = 51.478;

var mockLongitude = -0.166;

var mockAccuracy = 100.0;

function loadNext() {

- if (!window.testRunner || !window.internals)

- debug('This test can not run without testRunner or internals');

+ if (!window.testRunner || !window.mojo)

+ debug('This test can not run without testRunner or mojo');

- internals.setGeolocationClientMock(document);

- internals.setGeolocationPermission(document, true);

- internals.setGeolocationPosition(document, mockLatitude, mockLongitude, mockAccuracy);

+ geolocationServiceMock.then(mock => {

+ mock.setGeolocationPermission(true);

+ mock.setGeolocationPosition(mockLatitude, mockLongitude, mockAccuracy);

- navigator.geolocation.watchPosition(window.opener.gotPosition);

+ navigator.geolocation.watchPosition(window.opener.gotPosition);

+ });

}

</script>