third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-clear-watch.html - Issue 1948033003: Convert most geolocation layout tests to use a JS mock implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-clear-watch.html

Issue 1948033003: Convert most geolocation layout tests to use a JS mock implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-disconnect

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Geolocation/error.html ('k') | third_party/WebKit/LayoutTests/fast/dom/Geolocation/invalid-internals-arguments-no-crash.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-clear-watch.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-clear-watch.html b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-clear-watch.html

index 83c4583282057fbe98fd6d01d860b3e93dbf7b15..850993f3c99250c1f0c62e5b1f1c19cff2e1cd6a 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-clear-watch.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/error-clear-watch.html

@@ -2,23 +2,27 @@

<html>

<head>

+<script src="../../../resources/mojo-helpers.js"></script>

+<script src="resources/geolocation-mock.js"></script>

</head>

<body>

description("This tests removing the watcher from an error callback does not causes assertions.");

-if (!window.testRunner || !window.internals)

- debug('This test can not run without testRunner or internals');

+if (!window.testRunner || !window.mojo)

+ debug('This test can not run without testRunner or mojo');

-internals.setGeolocationPermission(document, true);

-internals.setGeolocationPositionUnavailableError(document, "debug");

+geolocationServiceMock.then(mock => {

+ mock.setGeolocationPermission(true);

+ mock.setGeolocationPositionUnavailableError("debug");

-var watchId = navigator.geolocation.watchPosition(function() {

- navigator.geolocation.clearWatch(watchId);

- finishJSTest();

-}, function(e) {

- navigator.geolocation.clearWatch(watchId);

- finishJSTest();

+ var watchId = navigator.geolocation.watchPosition(function() {

+ navigator.geolocation.clearWatch(watchId);

+ finishJSTest();

+ }, function(e) {

+ navigator.geolocation.clearWatch(watchId);

+ finishJSTest();

+ });

});