Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issue 1948033002: Reland of Disable flaky SyncSetupWebUITestAsync.VerifySignIn test on Windows. (Closed)

Created:
4 years, 7 months ago by martiniss
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam, sclittle
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable flaky SyncSetupWebUITestAsync.VerifySignIn test on Windows. (patchset #1 id:1 of https://codereview.chromium.org/1945113002/ ) Reason for revert: Change is ok, probably didn't cause outage. Original issue's description: > Revert of Disable flaky SyncSetupWebUITestAsync.VerifySignIn test on Windows. (patchset #1 id:1 of https://codereview.chromium.org/1951743003/ ) > > Reason for revert: > Speculative revert to fix https://crbug.com/608987, this might have broken CQ for chromium. > > Original issue's description: > > Disable flaky SyncSetupWebUITestAsync.VerifySignIn test on Windows. > > > > TBR=dbeam@chromium.org > > > > BUG=608975 > > > > Committed: https://chromium.googlesource.com/chromium/src/+/58963e58783c7534edfb01ed40bf25d1c0eb047b > > TBR=dbeam@chromium.org,sclittle@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=608975 > > Committed: https://crrev.com/50b717f96b3bfb07f39cec97c2dd77fd6fc49ba3 > Cr-Commit-Position: refs/heads/master@{#391407} TBR=dbeam@chromium.org,sclittle@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608975 Committed: https://crrev.com/7211509e83d5a95a88e44d4b564c390f56c4b5a6 Cr-Commit-Position: refs/heads/master@{#391549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/ui/webui/sync_setup_browsertest.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
martiniss
Created Reland of Disable flaky SyncSetupWebUITestAsync.VerifySignIn test on Windows.
4 years, 7 months ago (2016-05-04 17:20:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948033002/1
4 years, 7 months ago (2016-05-04 17:20:31 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-04 17:20:33 UTC) #4
sclittle
lgtm
4 years, 7 months ago (2016-05-04 17:21:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948033002/1
4 years, 7 months ago (2016-05-04 17:21:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 17:22:23 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 17:24:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7211509e83d5a95a88e44d4b564c390f56c4b5a6
Cr-Commit-Position: refs/heads/master@{#391549}

Powered by Google App Engine
This is Rietveld 408576698