Adds -Wno-deprecated-register to the build settings for iOS.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 4176 matching lines @@
               'OTHER_CFLAGS': [
                 '-Xclang', '-add-plugin', '-Xclang', '<(clang_add_plugin)',
               ],
             }],
             ['clang==1 and "<(GENERATOR)"=="ninja"', {
               'OTHER_CFLAGS': [
                 # See http://crbug.com/110262
                 '-fcolor-diagnostics',
               ],
             }],
+            # TODO(rohitrao): This flag is temporary and should be removed as
+            # soon as the iOS bots are updated to use Xcode 5.1.
+            ['OS=="ios" and ("<(GENERATOR)"=="xcode" or clang_xcode==1)', {

[rohitrao (ping after 24h), 2014/03/11 20:43:24]

This conditions clause works if I put it here, but not if I add a conditions
block inside xcode_settings in the ios block below (eg at line 4477).  I don't
understand why.

+              'WARNING_CFLAGS': [
+                '-Wno-unknown-warning-option',
+              ],
+            }],
           ],
         },
         'conditions': [
           ['clang==1', {
             'variables': {
               'clang_dir': '../third_party/llvm-build/Release+Asserts/bin',
             },
           }],
           ['asan==1', {
             'xcode_settings': {
@@ skipping 249 matching lines @@
           'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES',
           'WARNING_CFLAGS': [
             '-Wheader-hygiene',
             # Don't die on dtoa code that uses a char as an array index.
             # This is required solely for base/third_party/dmg_fp/dtoa.cc.
             '-Wno-char-subscripts',
             # See comment in the mac clang section above for this flag.
             '-Wno-unneeded-internal-declaration',
             # Match OS X clang C++11 warning settings.
             '-Wno-c++11-narrowing',
+            # As of Xcode 5.1, the register keyword is deprecated, but Chromium
+            # code still uses it.
+            '-Wno-deprecated-register',
           ],
 

[rohitrao (ping after 24h), 2014/03/11 20:43:24]

If I put the following code here, the flag gets ignored completely:

          'conditions': [
            ['"<(GENERATOR)"=="xcode" or clang_xcode==1', {
              'WARNING_CFLAGS': [
                '-Wno-unknown-warning-option',
              ],
            }],
          ],

[Mark Mentovai, 2014/03/11 20:46:38]

rohitrao wrote:
There is a conditions block right below this line already, and it will clobber
this one.

Write the condition inside of the existing conditions block.

           # Limit the valid architectures depending on "target_subarch".
           # This need to include the "arm" architectures but also the "x86"
           # ones (they are used when building for the simulator).
           'conditions': [
             ['target_subarch=="arm32"', {
               'VALID_ARCHS': ['armv7', 'i386'],
             }],
             ['target_subarch=="arm64"', {
               'VALID_ARCHS': ['arm64', 'x86_64'],
             }],
@@ skipping 574 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }