Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 194803002: Fix for 350887: CHECK failure on new_length->IsSmi() (Closed)

Created:
6 years, 9 months ago by mvstanton
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix for 350887: CHECK failure on new_length->IsSmi() In ElementsAccessorBase::SetLengthImpl for a dictionary array, we try to optimize setting array length if the new length is a smi. However, we refuse to set an array length to less than the index of the highest non-configurable array element. This index may be outside of smi range. Handle this case accordingly. BUG=350887 LOG=N R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M src/elements.cc View 1 chunk +9 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-350887.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dmitry Lomov (no reviews)
lgtm
6 years, 9 months ago (2014-03-11 10:26:45 UTC) #1
mvstanton
6 years, 9 months ago (2014-03-11 10:30:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r19787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698