Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1948013002: Fix failing RendererInitiatedCrossSiteNavigation test. (Closed)

Created:
4 years, 7 months ago by Charlie Reis
Modified:
4 years, 7 months ago
Reviewers:
Łukasz Anforowicz
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, site-isolation-reviews_chromium.org, clamy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix failing RendererInitiatedCrossSiteNavigation test. This PlzNavigate test is failing in the equivalent of --isolate-extensions mode (i.e., --isolate-sites-for-testing=*.is), which creates OOPIFs in some but not all cases. BUG=590782 TEST=Site Isolation Win FYI bot stays green. Committed: https://crrev.com/53b4ec38aa64684d39d67bc5148427b26036a8bc Cr-Commit-Position: refs/heads/master@{#391632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M content/browser/browser_side_navigation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/filters/isolate-extensions.content_browsertests.filter View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Charlie Reis
Lukasz, can you take a look? This fixes RendererInitiatedCrossSiteNavigation. I'm not sure why BrowserInitiatedNavigations was ...
4 years, 7 months ago (2016-05-04 17:28:27 UTC) #2
Łukasz Anforowicz
lgtm On 2016/05/04 17:28:27, Charlie Reis wrote: > Lukasz, can you take a look? This ...
4 years, 7 months ago (2016-05-04 19:13:48 UTC) #3
Charlie Reis
Thanks! +clamy@ as FYI.
4 years, 7 months ago (2016-05-04 19:33:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948013002/1
4 years, 7 months ago (2016-05-04 19:34:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 20:47:52 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:50:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53b4ec38aa64684d39d67bc5148427b26036a8bc
Cr-Commit-Position: refs/heads/master@{#391632}

Powered by Google App Engine
This is Rietveld 408576698