Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: mojo/dart/packages/mojo_services/lib/mojo/url_loader.mojom.dart

Issue 1948003003: Dart: Wait to handle events on a Stub until it makes sense to do it. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Add test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/packages/mojo_services/lib/mojo/url_loader.mojom.dart
diff --git a/mojo/dart/packages/mojo_services/lib/mojo/url_loader.mojom.dart b/mojo/dart/packages/mojo_services/lib/mojo/url_loader.mojom.dart
index f16385347d9091d1435ec0943c01c34f3682f762..f505a7aa905ad4ff7d54eaa72f76904b9695653f 100644
--- a/mojo/dart/packages/mojo_services/lib/mojo/url_loader.mojom.dart
+++ b/mojo/dart/packages/mojo_services/lib/mojo/url_loader.mojom.dart
@@ -713,14 +713,19 @@ class UrlLoaderProxy implements bindings.ProxyBase {
class UrlLoaderStub extends bindings.Stub {
- UrlLoader _impl = null;
+ UrlLoader _impl;
UrlLoaderStub.fromEndpoint(
- core.MojoMessagePipeEndpoint endpoint, [this._impl])
- : super.fromEndpoint(endpoint);
+ core.MojoMessagePipeEndpoint endpoint, [UrlLoader impl])
+ : super.fromEndpoint(endpoint, autoBegin: impl != null) {
+ _impl = impl;
+ }
- UrlLoaderStub.fromHandle(core.MojoHandle handle, [this._impl])
- : super.fromHandle(handle);
+ UrlLoaderStub.fromHandle(
+ core.MojoHandle handle, [UrlLoader impl])
+ : super.fromHandle(handle, autoBegin: impl != null) {
+ _impl = impl;
+ }
UrlLoaderStub.unbound() : super.unbound();
@@ -753,7 +758,9 @@ class UrlLoaderStub extends bindings.Stub {
0,
message);
}
- assert(_impl != null);
+ if (_impl == null) {
+ throw new core.MojoApiError("$this has no implementation set");
+ }
switch (message.header.type) {
case _urlLoaderMethodStartName:
var params = _UrlLoaderStartParams.deserialize(
@@ -826,10 +833,23 @@ class UrlLoaderStub extends bindings.Stub {
UrlLoader get impl => _impl;
set impl(UrlLoader d) {
- assert(_impl == null);
+ if (d == null) {
+ throw new core.MojoApiError("$this: Cannot set a null implementation");
+ }
+ if (isBound && (_impl == null)) {
+ beginHandlingEvents();
+ }
_impl = d;
}
+ @override
+ void bind(core.MojoMessagePipeEndpoint endpoint) {
+ super.bind(endpoint);
+ if (!isOpen && (_impl != null)) {
+ beginHandlingEvents();
+ }
+ }
+
String toString() {
var superString = super.toString();
return "UrlLoaderStub($superString)";

Powered by Google App Engine
This is Rietveld 408576698