mojo/dart/packages/mojo/lib/src/stub.dart - Issue 1948003003: Dart: Wait to handle events on a Stub until it makes sense to do it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/packages/mojo/lib/src/stub.dart

Issue 1948003003: Dart: Wait to handle events on a Stub until it makes sense to do it. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Add test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/dart/packages/mojo/lib/src/stub.dart

diff --git a/mojo/dart/packages/mojo/lib/src/stub.dart b/mojo/dart/packages/mojo/lib/src/stub.dart

index 4a17c7249796b48fb97824218f2637d05365c362..2b95ea777ee2a5af60721d3833e2a60658e2b77f 100644

--- a/mojo/dart/packages/mojo/lib/src/stub.dart

+++ b/mojo/dart/packages/mojo/lib/src/stub.dart

@@ -9,10 +9,12 @@ abstract class Stub extends core.MojoEventHandler {

bool _isClosing = false;

Completer _closeCompleter;

- Stub.fromEndpoint(core.MojoMessagePipeEndpoint endpoint)

- : super.fromEndpoint(endpoint);

+ Stub.fromEndpoint(core.MojoMessagePipeEndpoint endpoint,

+ {bool autoBegin: true})

+ : super.fromEndpoint(endpoint, autoBegin: autoBegin);

- Stub.fromHandle(core.MojoHandle handle) : super.fromHandle(handle);

+ Stub.fromHandle(core.MojoHandle handle, {bool autoBegin: true})

+ : super.fromHandle(handle, autoBegin: autoBegin);

Stub.unbound() : super.unbound();