Add plumbing for two gpu workarounds, soon to be used by DrawingBuffer.

Add plumbing for two gpu workarounds, soon to be used by DrawingBuffer.

The workaround disable_multisample_renderbuffer_color_mask is needed because
glColorMask does not work for multisample renderbuffers on old AMD GPUs.

The workaround disable_rgb_multisample_renderbuffer is needed because
multisample renderbuffers with format GL_RGB8 have performance issues on Intel
GPUs.

BUG=595948, 607130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/04a443352b363a4fdecee6c243ff5c02566a6795
Cr-Commit-Position: refs/heads/master@{#391780}

[erikchen, 2016-05-04 21:04:47]

Description was changed from

==========
Add plumbing for two gpu workarounds, soon to be used by DrawingBuffer.

The workaround disable_multisample_renderbuffer_color_mask is needed because
glColorMask does not work for multisample renderbuffers on old AMD GPUs.

The workaround disable_rgb_multisample_renderbuffer is needed because
multisample renderbuffers with format GL_RGB8 have performance issues on Intel
GPUs.

BUG=595948, 607130
==========

to

==========
Add plumbing for two gpu workarounds, soon to be used by DrawingBuffer.

The workaround disable_multisample_renderbuffer_color_mask is needed because
glColorMask does not work for multisample renderbuffers on old AMD GPUs.

The workaround disable_rgb_multisample_renderbuffer is needed because
multisample renderbuffers with format GL_RGB8 have performance issues on Intel
GPUs.

BUG=595948, 607130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-05-04 21:06:12]

erikchen@chromium.org changed reviewers:
+ kbr@chromium.org

[erikchen, 2016-05-04 21:06:12]

kbr: Please review.

[erikchen, 2016-05-04 21:23:11]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org, tsepez@chromium.org

[erikchen, 2016-05-04 21:23:12]

piman: Please review gpu/
tsepez: Please review gpu/ipc/common/gpu_command_buffer_traits_multi.h

[piman, 2016-05-04 21:36:19]

lgtm

[Ken Russell (switch to Gerrit), 2016-05-04 21:38:20]

lgtm w/nits

https://codereview.chromium.org/1947983003/diff/1/gpu/config/gpu_driver_bug_w...
File gpu/config/gpu_driver_bug_workaround_type.h (right):

https://codereview.chromium.org/1947983003/diff/1/gpu/config/gpu_driver_bug_w...
gpu/config/gpu_driver_bug_workaround_type.h:50:
disable_multisample_renderbuffer_color_mask)        \
I'd suggest making it more clear that this workaround targets only the WebGL
context's multisampled renderbuffer somehow. Maybe
disable_webgl_drawingbuffer_color_mask_usage?

https://codereview.chromium.org/1947983003/diff/1/gpu/config/gpu_driver_bug_w...
gpu/config/gpu_driver_bug_workaround_type.h:58:
disable_rgb_multisample_renderbuffer)               \
Maybe disable_webgl_drawingbuffer_rgb_multisampling_usage? Not that important,
but the disable_webgl_... prefix seems important to me.

[Tom Sepez, 2016-05-04 21:49:12]

traits lgtm

[erikchen, 2016-05-04 23:12:39]

https://codereview.chromium.org/1947983003/diff/1/gpu/config/gpu_driver_bug_w...
File gpu/config/gpu_driver_bug_workaround_type.h (right):

https://codereview.chromium.org/1947983003/diff/1/gpu/config/gpu_driver_bug_w...
gpu/config/gpu_driver_bug_workaround_type.h:50:
disable_multisample_renderbuffer_color_mask)        \
On 2016/05/04 21:38:20, Ken Russell wrote:
> I'd suggest making it more clear that this workaround targets only the WebGL
> context's multisampled renderbuffer somehow. Maybe
> disable_webgl_drawingbuffer_color_mask_usage?

I went with disable_webgl_multisampling_color_mask_usage, since we will still
use color masks (rgb emulation) for the non-multisampling case.

https://codereview.chromium.org/1947983003/diff/1/gpu/config/gpu_driver_bug_w...
gpu/config/gpu_driver_bug_workaround_type.h:58:
disable_rgb_multisample_renderbuffer)               \
On 2016/05/04 21:38:20, Ken Russell wrote:
> Maybe disable_webgl_drawingbuffer_rgb_multisampling_usage? Not that important,
> but the disable_webgl_... prefix seems important to me.

I went with disable_webgl_rgb_multisampling_usage

[erikchen, 2016-05-04 23:12:42]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-05-04 23:12:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
kbr@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1947983003/#ps20001
(title: "Comments from kbr@.")

[commit-bot: I haz the power, 2016-05-04 23:13:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947983003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947983003/20001

[commit-bot: I haz the power, 2016-05-05 02:20:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 02:20:57]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[erikchen, 2016-05-05 08:27:09]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-05-05 08:27:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947983003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947983003/20001

[commit-bot: I haz the power, 2016-05-05 09:17:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-05 09:18:42]

Description was changed from

==========
Add plumbing for two gpu workarounds, soon to be used by DrawingBuffer.

The workaround disable_multisample_renderbuffer_color_mask is needed because
glColorMask does not work for multisample renderbuffers on old AMD GPUs.

The workaround disable_rgb_multisample_renderbuffer is needed because
multisample renderbuffers with format GL_RGB8 have performance issues on Intel
GPUs.

BUG=595948, 607130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add plumbing for two gpu workarounds, soon to be used by DrawingBuffer.

The workaround disable_multisample_renderbuffer_color_mask is needed because
glColorMask does not work for multisample renderbuffers on old AMD GPUs.

The workaround disable_rgb_multisample_renderbuffer is needed because
multisample renderbuffers with format GL_RGB8 have performance issues on Intel
GPUs.

BUG=595948, 607130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/04a443352b363a4fdecee6c243ff5c02566a6795
Cr-Commit-Position: refs/heads/master@{#391780}
==========

[commit-bot: I haz the power, 2016-05-05 09:18:44]

Patchset 2 (id:??) landed as
https://crrev.com/04a443352b363a4fdecee6c243ff5c02566a6795
Cr-Commit-Position: refs/heads/master@{#391780}