Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1947953002: Add default Windows manifest to four .gn executables (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
bradnelson
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Add default Windows manifest to four .gn executables Windows executables need a manifest to specify OS compatibility. This is the last (?) change to add these manifests for Chromium. BUG=604060 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/7965517f3877641df646f0b4823920e24e8ea113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/tools/tls_edit/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/debug_stub/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator/driver/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brucedawson
This should be the last one - I hope. Just boilerplate additions, discussed with brettw@. ...
4 years, 7 months ago (2016-05-04 14:42:55 UTC) #2
bradnelson
lgtm lgtm rubberstamp
4 years, 7 months ago (2016-05-05 04:22:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947953002/1
4 years, 7 months ago (2016-05-05 04:22:47 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 05:15:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/7965517f3...

Powered by Google App Engine
This is Rietveld 408576698