Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1947943004: DevTools: [LiveSASS] do not commit updated SASS sources to file system. (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [LiveSASS] do not commit updated SASS sources to file system. With this patch in place, SASS changes will not be saved to file system; instead, a working copy of files will be changed. User will have to save changed SASS files manually. BUG=608106 R=pfeldman Committed: https://crrev.com/a05638f5d217da949f614a6aaae67a0711b0e151 Cr-Commit-Position: refs/heads/master@{#392781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
lushnikov
ptal
4 years, 7 months ago (2016-05-04 23:21:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947943004/1
4 years, 7 months ago (2016-05-04 23:22:53 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/65344)
4 years, 7 months ago (2016-05-05 02:21:44 UTC) #6
pfeldman
lgtm
4 years, 7 months ago (2016-05-05 22:19:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947943004/1
4 years, 7 months ago (2016-05-05 22:22:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947943004/1
4 years, 7 months ago (2016-05-10 23:04:52 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 00:15:02 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 00:16:47 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a05638f5d217da949f614a6aaae67a0711b0e151
Cr-Commit-Position: refs/heads/master@{#392781}

Powered by Google App Engine
This is Rietveld 408576698