[v8-dev] ARM: safepoints frame optimization

src/arm/lithium-codegen-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 49 matching lines @@
 };
 
 
 #define __ masm()->
 
 bool LCodeGen::GenerateCode() {
   LPhase phase("Z_Code generation", chunk());
   ASSERT(is_unused());
   status_ = GENERATING;
 
+  chunk()->add_safepoints_registers(r10.bit() | fp.bit());
+  // Add some double registers to save to be able to save all registers with
+  // only two vstm instructions.
+  int first = -1;
+  int last = -1;
+  for (int i = 0; i < LowDwVfpRegister::kMaxNumLowRegisters; i++) {
+    if ((chunk()->safepoints_double_registers() & (1 << i)) != 0) {
+      if (first == -1) first = i;
+      last = i;
+    }
+  }
+  if (first != -1) {
+    chunk()->add_safepoints_double_registers(
+        ((1 << last) - 1) & ~((1 << first) - 1));
+  }
+  first = -1;
+  last = -1;
+  for (int i = LowDwVfpRegister::kMaxNumLowRegisters;
+       i < DoubleRegister::NumRegisters();
+       i++) {
+    if ((chunk()->safepoints_double_registers() & (1 << i)) != 0) {
+      if (first == -1) first = i;
+      last = i;
+    }
+  }
+  if (first != -1) {
+    chunk()->add_safepoints_double_registers(
+        ((1 << last) - 1) & ~((1 << first) - 1));
+  }
+  masm_->set_registers_masks(chunk()->safepoints_registers(),
+                             chunk()->safepoints_double_registers());
+
   // Open a frame scope to indicate that there is a frame on the stack.  The
   // NONE indicates that the scope shouldn't actually generate code to set up
   // the frame (that is done in GeneratePrologue).
   FrameScope frame_scope(masm_, StackFrame::NONE);
 
   return GeneratePrologue() &&
       GenerateBody() &&
       GenerateDeferredCode() &&
       GenerateDeoptJumpTable() &&
       GenerateSafepointTable();
@@ skipping 4990 matching lines @@
 
 
 void LCodeGen::DoDeferredInstanceMigration(LCheckMaps* instr, Register object) {
   {
     PushSafepointRegistersScope scope(this, Safepoint::kWithRegisters);
     __ push(object);
     __ mov(cp, Operand::Zero());
     __ CallRuntimeSaveDoubles(Runtime::kTryMigrateInstance);
     RecordSafepointWithRegisters(
         instr->pointer_map(), 1, Safepoint::kNoLazyDeopt);
-    __ StoreToSafepointRegisterSlot(r0, scratch0());
+    ASSERT((chunk()->safepoints_registers() & scratch0().bit()) == 0);
+    __ mov(scratch0(), r0);
   }
   __ tst(scratch0(), Operand(kSmiTagMask));
   DeoptimizeIf(eq, instr->environment());
 }
 
 
 void LCodeGen::DoCheckMaps(LCheckMaps* instr) {
   class DeferredCheckMaps V8_FINAL : public LDeferredCode {
    public:
     DeferredCheckMaps(LCodeGen* codegen, LCheckMaps* instr, Register object)
@@ skipping 642 matching lines @@
   __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
   __ ldr(result, FieldMemOperand(scratch,
                                  FixedArray::kHeaderSize - kPointerSize));
   __ bind(&done);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal