[v8-dev] ARM: safepoints frame optimization

src/arm/assembler-arm.h

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
 // are met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 1428 matching lines @@
   static const int kMaxNumPending32RelocInfo = kMaxDistToIntPool/kInstrSize;
   static const int kMaxNumPending64RelocInfo = kMaxDistToFPPool/kInstrSize;
 
   // Postpone the generation of the constant pool for the specified number of
   // instructions.
   void BlockConstPoolFor(int instructions);
 
   // Check if is time to emit a constant pool.
   void CheckConstPool(bool force_emit, bool require_jump);
 
+  RegList registers_mask() const { return registers_mask_; }
+  RegList double_registers_mask() const { return double_registers_mask_; }
+  void set_registers_masks(RegList registers_mask,

[Benedikt Meurer, 2014/03/13 10:41:49]

Nit: One dedicated setter per property.

[vincent.belliard, 2014/03/13 10:53:37]

The aim was to ensure that both masks would always been set at the same time
(and so we never forget to set one). If you prefer two functions, I will change
it.

+                           RegList double_registers_mask) {
+    registers_mask_ = registers_mask;
+    double_registers_mask_ = double_registers_mask;
+  }
+
  protected:
   // Relocation for a type-recording IC has the AST id added to it.  This
   // member variable is a way to pass the information from the call site to
   // the relocation info.
   TypeFeedbackId recorded_ast_id_;
 
   int buffer_space() const { return reloc_info_writer.pos() - pc_; }
 
   // Decode branch instruction at pos and return branch target pos
   int target_at(int pos);
@@ skipping 93 matching lines @@
   RelocInfo pending_32_bit_reloc_info_[kMaxNumPending32RelocInfo];
   RelocInfo pending_64_bit_reloc_info_[kMaxNumPending64RelocInfo];
   // Number of pending reloc info entries in the 32 bits buffer.
   int num_pending_32_bit_reloc_info_;
   // Number of pending reloc info entries in the 64 bits buffer.
   int num_pending_64_bit_reloc_info_;
 
   // The bound position, before this we cannot do instruction elimination.
   int last_bound_pos_;
 
+  RegList registers_mask_;
+  RegList double_registers_mask_;
+
   // Code emission
   inline void CheckBuffer();
   void GrowBuffer();
   inline void emit(Instr x);
 
   // 32-bit immediate values
   void move_32_bit_immediate(Condition cond,
                              Register rd,
                              SBit s,
                              const Operand& x);
@@ skipping 35 matching lines @@
  public:
   explicit EnsureSpace(Assembler* assembler) {
     assembler->CheckBuffer();
   }
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_ARM_ASSEMBLER_ARM_H_