Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1947923004: [MD settings] separator line for side nav (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update from Alan Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_menu/settings_menu.html
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html
index e1dee73fa682ab96f6dbfe8e5193c9700b7aab1f..e7b8e339f08f90dc9aa6624eaa4d6bc3b63db6a2 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html
@@ -66,6 +66,14 @@
font-weight: 500;
min-height: 40px;
}
+
+ .menu-top-margin {
+ margin-top: 8px;
tommycli 2016/05/06 18:23:48 Does it work if you put margin-bottom on every "pa
dschuyler 2016/05/06 23:58:24 Done.
+ }
+
+ .underbar {
+ border-bottom: 1px solid rgba(0, 0, 0, 0.08);
tommycli 2016/05/06 18:23:48 Alan really doesn't want to use the default --sett
dschuyler 2016/05/06 23:58:24 Done.
+ }
</style>
<paper-menu name="root-menu">
<paper-submenu data-page="basic" id="basicPage">
@@ -112,7 +120,8 @@
</paper-menu>
</paper-submenu>
<paper-submenu id="advancedPage" data-page="advanced">
- <div class="menu-trigger" data-section="" on-tap="openPage_">
+ <div class="menu-top-margin menu-trigger" data-section=""
+ on-tap="openPage_">
<span i18n-content="advancedPageTitle"></span>
<iron-icon icon="[[arrowState_(advancedOpened_)]]" item-icon>
</iron-icon>
@@ -163,8 +172,9 @@
</div>
</paper-menu>
</paper-submenu>
+ <div class="menu-top-margin underbar"></div>
<paper-submenu on-tap="openPage_">
- <div class="menu-trigger">
+ <div class="menu-top-margin menu-trigger">
<span i18n-content="aboutProgram"></span>
</div>
</paper-submenu>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698