remoting: fix out-of-tree build

remoting/remoting_options.gni

Index: remoting/remoting_options.gni
diff --git a/remoting/remoting_options.gni b/remoting/remoting_options.gni
index a944b3a9c573c35c1e0b6b764b05752d0de5e182..d9c94300064445bf5a04f27aa5a69598dabd712d 100644
--- a/remoting/remoting_options.gni
+++ b/remoting/remoting_options.gni
@@ -29,9 +29,9 @@ if (is_win) {
 remoting_rdp_session = 1
 
 if (is_chrome_branded) {
-  branding_path = rebase_path("//remoting/branding_Chrome", root_build_dir)
+  branding_path = rebase_path("//remoting/branding_Chrome")

[brettw, 2016/05/04 16:41:39]

For this kind of thing, we should define the globals to be the correct thing in
every context, which to me is just:
  branding_path = "//remoting/branding_Chrome"
and then have users of that variable rebase it to what they need at the time.
Different callers can easily have different expectations of what they want it to
be relative to, and making assumptions that a certain global path is
system-absolute in random BUILD files will be fragile.

It looks like there are only a couple of places that use this variable.

[Paweł Hajdan Jr., 2016/05/05 13:22:55]

Done.

 } else {
-  branding_path = rebase_path("//remoting/branding_Chromium", root_build_dir)
+  branding_path = rebase_path("//remoting/branding_Chromium")
 }
 
 # The ar_service_environment variable is used to define the target