Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 194783002: Use MigrateToMap instead of set_map to update the map of a JSObject. (Closed)

Created:
6 years, 9 months ago by Toon Verwaest
Modified:
6 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Use MigrateToMap instead of set_map to update the map of a JSObject. This is necessary to guarantee correct representation usage. Some unhandlified code still needs to be handlified before we can push this through fully. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19844

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -87 lines) Patch
M src/objects.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M src/objects.cc View 1 22 chunks +73 lines, -78 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL. Prerequisite for introducing a mutable heap number instance type (and double unboxing).
6 years, 9 months ago (2014-03-11 10:00:37 UTC) #1
Igor Sheludko
lgtm with nits: https://codereview.chromium.org/194783002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/194783002/diff/1/src/objects.cc#newcode2338 src/objects.cc:2338: int number_of_fields = NumberOfFields(NumberOfOwnDescriptors()); NumberOfFields() would ...
6 years, 9 months ago (2014-03-11 14:17:36 UTC) #2
Toon Verwaest
Addressed comment
6 years, 9 months ago (2014-03-11 14:45:10 UTC) #3
Toon Verwaest
6 years, 9 months ago (2014-03-12 13:18:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19844 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698