Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1947813002: More strong mode clean-up (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -154 lines) Patch
M pkg/analysis_server/test/integration/integration_tests.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/cancelable_future.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 1 chunk +179 lines, -147 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-05-04 13:20:02 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-04 13:58:13 UTC) #3
Brian Wilkerson
4 years, 7 months ago (2016-05-04 14:42:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
08241e907277a5579f0daf19f49d501be7e8c7dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698