If image sizes are greater than 32768, fixed point stepping will overflow an int. This CL changes t…

unit_test/unit_test.h

 /*
  *  Copyright 2011 The LibYuv Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS. All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 10 matching lines @@
 #include <gtest/gtest.h>
 
 #include "libyuv/basic_types.h"
 
 static __inline int Abs(int v) {
   return v >= 0 ? v : -v;
 }
 
 #define OFFBY 0
 
+// Scaling uses 16.16 fixed point to step thru the source image, so a
+// maximum size of 32767.999 can be expressed.  32768 is valid because
+// the step is 1 beyond the image but not used.
+// Destination size is mainly constrained by valid scale step not the 
+// absolute size, so it may be possible to relax the destination size
+// constraint.
+// Source size is unconstrained for most specialized scalers.  e.g.
+// An image of 65536 scaled to half size would be valid.  The test 
+// could be relaxed for special scale factors.
+// If this test is removed, the scaling function should gracefully
+// fail with a return code.  The test could be changed to know that
+// libyuv failed in a controlled way.
+
+static const int kMaxWidth = 32768;
+static const int kMaxHeight = 32768;
+
+static inline bool SizeValid(int src_width, int src_height,
+                             int dst_width, int dst_height) {
+  if (src_width > kMaxWidth || src_height > kMaxHeight ||
+      dst_width > kMaxWidth || dst_height > kMaxHeight) {
+    printf("Warning - size too large to test.  Skipping\n");
+    return false;
+  }
+  return true;
+}
+
 #define align_buffer_page_end(var, size)                                       \
   uint8* var;                                                                  \
   uint8* var##_mem;                                                            \
   var##_mem = reinterpret_cast<uint8*>(malloc((((size) + 4095) & ~4095) +      \
       OFFBY));                                                                 \
   var = var##_mem + (-(size) & 4095) + OFFBY;
 
 #define free_aligned_buffer_page_end(var) \
   free(var##_mem);  \
   var = 0;
@@ skipping 103 matching lines @@
   int benchmark_iterations_;  // Default 1. Use 1000 for benchmarking.
   int benchmark_width_;  // Default 1280.  Use 640 for benchmarking VGA.
   int benchmark_height_;  // Default 720.  Use 360 for benchmarking VGA.
   int benchmark_pixels_div256_;  // Total pixels to benchmark / 256.
   int benchmark_pixels_div1280_;  // Total pixels to benchmark / 1280.
   int disable_cpu_flags_;  // Default 1.  Use -1 for benchmarking.
   int benchmark_cpu_info_;  // Default -1.  Use 1 to disable SIMD.
 };
 
 #endif  // UNIT_TEST_UNIT_TEST_H_  NOLINT