If image sizes are greater than 32768, fixed point stepping will overflow an int. This CL changes t…

If image sizes are greater than 32768, fixed point stepping will overflow an int. This CL changes the max size to 32768 and disables the test if larger.

BUG=libyuv:590
TESTED=LIBYUV_FLAGS=-1 LIBYUV_WIDTH=8192 LIBYUV_HEIGHT=16 out/Release/libyuv_unittest --gtest_filter=*
R=harryjin@google.com

Committed: https://chromium.googlesource.com/libyuv/libyuv/+/07cb92272f393f91f8d6215633fbbaa04bbf0a1f

[fbarchard1, 2016-05-03 23:57:40]

Description was changed from

==========
If image sizes are greater than 32768, fixed point stepping will overflow an
int. This CL changes the max size to 32768 and disables the test if larger.

BUG=590
TESTED=LIBYUV_FLAGS=-1 LIBYUV_WIDTH=8192 LIBYUV_HEIGHT=16
out/Release/libyuv_unittest --gtest_filter=*
R=harryjin@google.com
==========

to

==========
If image sizes are greater than 32768, fixed point stepping will overflow an
int. This CL changes the max size to 32768 and disables the test if larger.

BUG=libyuv:590
TESTED=LIBYUV_FLAGS=-1 LIBYUV_WIDTH=8192 LIBYUV_HEIGHT=16
out/Release/libyuv_unittest --gtest_filter=*
R=harryjin@google.com
==========

[harryjin, 2016-05-04 04:33:44]

https://codereview.chromium.org/1947783002/diff/20001/unit_test/scale_argb_te...
File unit_test/scale_argb_test.cc (right):

https://codereview.chromium.org/1947783002/diff/20001/unit_test/scale_argb_te...
unit_test/scale_argb_test.cc:31: if (src_width > 32768 || src_height > 32768 ||
Use a constant?

https://codereview.chromium.org/1947783002/diff/20001/unit_test/scale_argb_te...
unit_test/scale_argb_test.cc:31: if (src_width > 32768 || src_height > 32768 ||
This whole check can be refactored out to a helper method?

[fbarchard1, 2016-05-05 23:37:02]

Test still passes..

[       OK ] LibYUVScaleTest.ScaleFrom1280x720_Box (4 ms)
[----------] 194 tests from LibYUVScaleTest (1263 ms total)

[----------] Global test environment tear-down
[==========] 974 tests from 6 test cases ran. (4989 ms total)
[  PASSED  ] 974 tests.

  YOU HAVE 86 DISABLED TESTS

https://codereview.chromium.org/1947783002/diff/20001/unit_test/scale_argb_te...
File unit_test/scale_argb_test.cc (right):

https://codereview.chromium.org/1947783002/diff/20001/unit_test/scale_argb_te...
unit_test/scale_argb_test.cc:31: if (src_width > 32768 || src_height > 32768 ||
On 2016/05/04 04:33:44, harryjin wrote:
> Use a constant?

Done.

https://codereview.chromium.org/1947783002/diff/20001/unit_test/scale_argb_te...
unit_test/scale_argb_test.cc:31: if (src_width > 32768 || src_height > 32768 ||
On 2016/05/04 04:33:44, harryjin wrote:
> This whole check can be refactored out to a helper method?

Done.

[harryjin, 2016-05-06 01:57:01]

lgtm

[fbarchard1, 2016-05-06 02:09:05]

Description was changed from

==========
If image sizes are greater than 32768, fixed point stepping will overflow an
int. This CL changes the max size to 32768 and disables the test if larger.

BUG=libyuv:590
TESTED=LIBYUV_FLAGS=-1 LIBYUV_WIDTH=8192 LIBYUV_HEIGHT=16
out/Release/libyuv_unittest --gtest_filter=*
R=harryjin@google.com
==========

to

==========
If image sizes are greater than 32768, fixed point stepping will overflow an
int. This CL changes the max size to 32768 and disables the test if larger.

BUG=libyuv:590
TESTED=LIBYUV_FLAGS=-1 LIBYUV_WIDTH=8192 LIBYUV_HEIGHT=16
out/Release/libyuv_unittest --gtest_filter=*
R=harryjin@google.com

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/07cb92272f393f91f8d6215633f...
==========

[fbarchard1, 2016-05-06 02:09:06]

Committed patchset #5 (id:80001) manually as
07cb92272f393f91f8d6215633fbbaa04bbf0a1f (presubmit successful).