Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1947753002: More efficient identification of dynamic and void types. (Closed)

Created:
4 years, 7 months ago by regis
Modified:
4 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More efficient identification of dynamic and void types. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/5294523c205a9fd3ef541dff19596a6d8c42d5a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M runtime/vm/code_generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +7 lines, -13 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 7 months ago (2016-05-03 21:52:40 UTC) #2
siva
lgtm
4 years, 7 months ago (2016-05-03 23:06:14 UTC) #3
regis
4 years, 7 months ago (2016-05-03 23:08:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5294523c205a9fd3ef541dff19596a6d8c42d5a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698