Add aliasing disambiguation for typed data lists.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/cpu.h"
 #include "vm/dart_entry.h"
@@ skipping 5574 matching lines @@
   const PhiPlaceMoves* phi_moves() const { return phi_moves_; }
 
   // Returns true if the result of an allocation instruction can be aliased by
   // some other SSA variable and false otherwise. Currently simply checks if
   // this value is stored in a field, escapes to another function or
   // participates in a phi.
   static bool CanBeAliased(Definition* alloc) {
     ASSERT(alloc->IsAllocateObject() ||
            alloc->IsCreateArray() ||
            (alloc->IsStaticCall() &&
-            alloc->AsStaticCall()->is_known_list_constructor()));
+            alloc->AsStaticCall()->IsRecognizedFactory()));
     if (alloc->Identity() == kIdentityUnknown) {
       bool escapes = false;
       for (Value* use = alloc->input_use_list();
            use != NULL;
            use = use->next_use()) {
         Instruction* instr = use->instruction();
         if (instr->IsPushArgument() ||
             (instr->IsStoreInstanceField()
              && (use->use_index() != StoreInstanceFieldInstr::kInstancePos)) ||
             (instr->IsStoreIndexed()
@@ skipping 66 matching lines @@
     return GetFieldId(instance_id, field);
   }
 
   intptr_t GetInstanceVMFieldId(Definition* defn, intptr_t offset) {
     intptr_t instance_id = kAnyInstance;
 
     ASSERT(defn != NULL);
     if ((defn->IsAllocateObject() ||
          defn->IsCreateArray() ||
          (defn->IsStaticCall() &&
-          defn->AsStaticCall()->is_known_list_constructor())) &&
+          defn->AsStaticCall()->IsRecognizedFactory())) &&
         !CanBeAliased(defn)) {
       instance_id = defn->ssa_temp_index();
       ASSERT(instance_id != kAnyInstance);
     }
 
     intptr_t id = vm_field_ids_.Lookup(VMFieldIdPair::Key(instance_id, offset));
     if (id == 0) {
       id = ++max_vm_field_id_;
       vm_field_ids_.Insert(
           VMFieldIdPair(VMFieldIdPair::Key(instance_id, offset), id));
     }
     return id;
   }
 
   intptr_t GetInstanceIndexId(Definition* defn, intptr_t index) {
     intptr_t instance_id = kAnyInstance;
 
     ASSERT(defn != NULL);
     if ((defn->IsCreateArray() ||
          (defn->IsStaticCall() &&
-          defn->AsStaticCall()->is_known_list_constructor())) &&
+          defn->AsStaticCall()->IsRecognizedFactory())) &&
         !CanBeAliased(defn)) {
       instance_id = defn->ssa_temp_index();
       ASSERT(instance_id != kAnyInstance);
     }
 
     return GetIndexId(instance_id, index);
   }
 
   intptr_t GetUnknownIndexId(Definition* defn) {
     intptr_t instance_id = kAnyInstance;
 
     ASSERT(defn != NULL);
     if ((defn->IsCreateArray() ||
          (defn->IsStaticCall() &&
-          defn->AsStaticCall()->is_known_list_constructor())) &&
+          defn->AsStaticCall()->IsRecognizedFactory())) &&
         !CanBeAliased(defn)) {
       instance_id = defn->ssa_temp_index();
       ASSERT(instance_id != kAnyInstance);
     }
 
     intptr_t id = unknown_index_ids_.Lookup(
         UnknownIndexIdPair::Key(instance_id));
     if (id == 0) {
       // Zero is used to indicate element not found. The first id is one.
       id = ++max_unknown_index_id_;
@@ skipping 3307 matching lines @@
   }
 
   // Insert materializations at environment uses.
   for (intptr_t i = 0; i < exits.length(); i++) {
     CreateMaterializationAt(exits[i], alloc, alloc->cls(), *slots);
   }
 }
 
 
 }  // namespace dart