Issue 1947723002: Update core/errors.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1947723002: Update core/errors.dart (Closed)

Created:
4 years, 7 months ago by sra1

Modified:
4 years, 7 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler@master

Target Ref:
refs/heads/master

Visibility:
Public.

Update core/errors.dart Also - update some error helpers functions in the js runtime. - add 'int' to stringFromCharCode to avoid dcalls. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/9302f2d457c284dbeb6a86f827e4c09f1f8b766e

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+204 lines, -109 lines)			Patch
M	lib/runtime/dart_sdk.js	View	12 chunks	+98 lines, -55 lines	0 comments	Download
M	tool/input_sdk/lib/core/errors.dart	View	6 chunks	+45 lines, -31 lines	0 comments	Download
M	tool/input_sdk/private/js_helper.dart	View	4 chunks	+60 lines, -22 lines	0 comments	Download
M	tool/sdk_expected_errors.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

sra1

4 years, 7 months ago (2016-05-04 17:41:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9302f2d457c284dbeb6a86f827e4c09f1f8b766e (presubmit successful).