Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4931)

Unified Diff: chrome/renderer/resources/neterror.html

Issue 19477006: Use dinosaur icon on "you are offline" error page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/localized_error.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/neterror.html
diff --git a/chrome/renderer/resources/neterror.html b/chrome/renderer/resources/neterror.html
index 41c80c8d92b0798cd22c06bdf86086209c0af2c5..1117dfe9ccbe19c41f7af02063cdcb410bb1693c 100644
--- a/chrome/renderer/resources/neterror.html
+++ b/chrome/renderer/resources/neterror.html
@@ -55,7 +55,11 @@ a {
text-decoration: none;
}
-.error-img {
+.icon {
+ -webkit-user-select: none;
+}
+
+.icon-generic {
/**
* Can't access chrome://theme/IDR_ERROR_NETWORK_GENERIC from an untrusted
* renderer process, so embed the resource manually.
@@ -63,7 +67,12 @@ a {
content: -webkit-image-set(
url('../../app/theme/default_100_percent/common/error_network_generic.png') 1x,
url('../../app/theme/default_200_percent/common/error_network_generic.png') 2x);
- -webkit-user-select: none;
+}
+
+.icon-offline {
+ content: -webkit-image-set(
+ url('../../app/theme/default_100_percent/common/error_network_offline.png') 1x,
+ url('../../app/theme/default_200_percent/common/error_network_offline.png') 2x);
}
#content-top {
@@ -320,7 +329,7 @@ function updateForDnsProbe(strings) {
<div id="box">
<div id="content-top">
<h1>
- <div><img class="error-img"></div>
+ <div><img class="icon" jseval="this.classList.add(iconClass)"></div>
<span i18n-content="heading"></span>
</h1>
@@ -347,7 +356,7 @@ function updateForDnsProbe(strings) {
<div id="sub-frame-error">
<!-- Show details when hovering over the icon, in case the details are
hidden because they're too large. -->
- <img class="error-img" jsvalues=".title:errorDetails">
+ <img class="icon" jseval="this.classList.add(iconClass)" jsvalues=".title:errorDetails">
<div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div>
</div>
</body>
« no previous file with comments | « chrome/common/localized_error.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698