Chromium Code Reviews Chromium Code Reviews
Issue 19477006:
Use dinosaur icon on "you are offline" error page. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html i18n-values="dir:textdirection"> | 2 <html i18n-values="dir:textdirection"> |
| 3 <head> | 3 <head> |
| 4 <meta name="viewport" content="width=device-width, initial-scale=1.0, | 4 <meta name="viewport" content="width=device-width, initial-scale=1.0, |
| 5 maximum-scale=1.0, user-scalable=no"> | 5 maximum-scale=1.0, user-scalable=no"> |
| 6 <title i18n-content="title"> | 6 <title i18n-content="title"> |
| 7 </title> | 7 </title> |
| 8 <style> | 8 <style> |
| 9 | 9 |
| 10 body { | 10 body { |
| (...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 48 margin: 10px 0px 25px 0px; | 48 margin: 10px 0px 25px 0px; |
| 49 font-weight: normal; | 49 font-weight: normal; |
| 50 font-size: 1.5em; | 50 font-size: 1.5em; |
| 51 } | 51 } |
| 52 | 52 |
| 53 a { | 53 a { |
| 54 color: #15c; | 54 color: #15c; |
| 55 text-decoration: none; | 55 text-decoration: none; |
| 56 } | 56 } |
| 57 | 57 |
| 58 .error-img { | 58 .icon { |
| 59 -webkit-user-select: none; | |
| 60 } | |
| 61 | |
| 62 .icon-generic { | |
| 59 /** | 63 /** |
| 60 * Can't access chrome://theme/IDR_ERROR_NETWORK_GENERIC from an untrusted | 64 * Can't access chrome://theme/IDR_ERROR_NETWORK_GENERIC from an untrusted |
| 61 * renderer process, so embed the resource manually. | 65 * renderer process, so embed the resource manually. |
| 62 */ | 66 */ |
| 63 content: -webkit-image-set( | 67 content: -webkit-image-set( |
| 64 url('../../app/theme/default_100_percent/common/error_network_generic.png' ) 1x, | 68 url('../../app/theme/default_100_percent/common/error_network_generic.png' ) 1x, |
| 65 url('../../app/theme/default_200_percent/common/error_network_generic.png' ) 2x); | 69 url('../../app/theme/default_200_percent/common/error_network_generic.png' ) 2x); |
| 66 -webkit-user-select: none; | 70 } |
| 71 | |
| 72 .icon-offline { | |
| 73 content: -webkit-image-set( | |
| 74 url('../../app/theme/default_100_percent/common/error_network_offline.png' ) 1x, | |
| 75 url('../../app/theme/default_200_percent/common/error_network_offline.png' ) 2x); | |
| 67 } | 76 } |
| 68 | 77 |
| 69 #content-top { | 78 #content-top { |
| 70 margin: 20px 20px 20px 25px; | 79 margin: 20px 20px 20px 25px; |
| 71 } | 80 } |
| 72 | 81 |
| 73 #help-box-outer { | 82 #help-box-outer { |
| 74 overflow: hidden; | 83 overflow: hidden; |
| 75 -webkit-transition: height ease-in 218ms; | 84 -webkit-transition: height ease-in 218ms; |
| 76 } | 85 } |
| (...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 313 jstProcess(context, document.getElementById('details')); | 322 jstProcess(context, document.getElementById('details')); |
| 314 } | 323 } |
| 315 | 324 |
| 316 </script> | 325 </script> |
| 317 | 326 |
| 318 <body id="t"> | 327 <body id="t"> |
| 319 <div id="main-frame-error"> | 328 <div id="main-frame-error"> |
| 320 <div id="box"> | 329 <div id="box"> |
| 321 <div id="content-top"> | 330 <div id="content-top"> |
| 322 <h1> | 331 <h1> |
| 323 <div><img class="error-img"></div> | 332 <div><img class="icon" jsvalues=".className:iconClass"></div> |
|
mmenke
2013/07/24 18:45:42
Doesn't setting classname overwrite the current cl
newt (away)
2013/07/24 21:02:35
Good catch. Fixed. (it's "this" btw)
| |
| 324 <span i18n-content="heading"></span> | 333 <span i18n-content="heading"></span> |
| 325 </h1> | 334 </h1> |
| 326 | 335 |
| 327 <button id="reload-button" onclick="location = this.url" jsselect="reload" j svalues=".url:reloadUrl" jscontent="msg"></button> | 336 <button id="reload-button" onclick="location = this.url" jsselect="reload" j svalues=".url:reloadUrl" jscontent="msg"></button> |
| 328 <button id="more-less-button" onclick="toggleHelpBox()" jsdisplay="more" jsv alues=".moreText:more; .lessText:less;" jscontent="more"></button> | 337 <button id="more-less-button" onclick="toggleHelpBox()" jsdisplay="more" jsv alues=".moreText:more; .lessText:less;" jscontent="more"></button> |
| 329 </div> | 338 </div> |
| 330 | 339 |
| 331 <!-- Outer and inner divs are needed both for margins and sizing. --> | 340 <!-- Outer and inner divs are needed both for margins and sizing. --> |
| 332 <div id="help-box-outer" class="hidden"> | 341 <div id="help-box-outer" class="hidden"> |
| 333 <div id="help-box-inner"> | 342 <div id="help-box-inner"> |
| 334 <div jsselect="summary"> | 343 <div jsselect="summary"> |
| 335 <span jsvalues=".innerHTML:msg"></span> | 344 <span jsvalues=".innerHTML:msg"></span> |
| 336 </div> | 345 </div> |
| 337 | 346 |
| 338 <div class="suggestions" jsselect="suggestions"> | 347 <div class="suggestions" jsselect="suggestions"> |
| 339 <div class="suggestion-header" jsvalues=".innerHTML:header"></div> | 348 <div class="suggestion-header" jsvalues=".innerHTML:header"></div> |
| 340 <div class="suggestion-body" jsvalues=".innerHTML:body"></div> | 349 <div class="suggestion-body" jsvalues=".innerHTML:body"></div> |
| 341 </div> | 350 </div> |
| 342 <div class="error-code" jscontent="errorCode"></div> | 351 <div class="error-code" jscontent="errorCode"></div> |
| 343 </div> | 352 </div> |
| 344 </div> | 353 </div> |
| 345 </div> | 354 </div> |
| 346 </div> | 355 </div> |
| 347 <div id="sub-frame-error"> | 356 <div id="sub-frame-error"> |
| 348 <!-- Show details when hovering over the icon, in case the details are | 357 <!-- Show details when hovering over the icon, in case the details are |
| 349 hidden because they're too large. --> | 358 hidden because they're too large. --> |
| 350 <img class="error-img" jsvalues=".title:errorDetails"> | 359 <img class="error-img" jsvalues=".title:errorDetails"> |
|
mmenke
2013/07/24 18:45:42
Need to modify this, icon, too, for iframes (Admit
newt (away)
2013/07/24 21:02:35
Done.
| |
| 351 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div> | 360 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div> |
| 352 </div> | 361 </div> |
| 353 </body> | 362 </body> |
| 354 </html> | 363 </html> |
| OLD | NEW |
