Improve Skia configuration.

skia/skia_library_opts.gyp

Index: skia/skia_library_opts.gyp
===================================================================
--- skia/skia_library_opts.gyp	(revision 225491)
+++ skia/skia_library_opts.gyp	(working copy)
@@ -27,7 +27,11 @@
     {
       'target_name': 'skia_opts',
       'type': 'static_library',
+      'includes': [
+        'skia_common.gypi',
+      ],
       'include_dirs': [
+        '..',

[djsollen, 2013/09/27 13:52:25]

if '..' is now a requirement due to the something defined in skia_common.gypi
shouldn't it be added to the include list in that file instead of all the
targets that use it?

[bungeman-skia, 2013/09/27 17:59:13]

Hmmm... it was kind of a requirement before, but this one got away without it.
However, seeing as how all of these need '..' and 'config', that should probably
move to common. There are actually many more things that should move to common,
but I'm trying to keep this change a bit smaller. Done.

         'config',
         '../third_party/skia/include/config',
         '../third_party/skia/include/core',
@@ -134,6 +138,9 @@
     {
       'target_name': 'skia_opts_ssse3',
       'type': 'static_library',
+      'includes': [
+        'skia_common.gypi',
+      ],
       'include_dirs': [
         '..',
         'config',
@@ -172,6 +179,9 @@
     {
       'target_name': 'skia_opts_none',
       'type': 'static_library',
+      'includes': [
+        'skia_common.gypi',
+      ],
       'include_dirs': [
         '..',
         'config',
@@ -197,6 +207,9 @@
         {
           'target_name': 'skia_opts_neon',
           'type': 'static_library',
+          'includes': [
+            'skia_common.gypi',
+          ],
           'include_dirs': [
             '..',
             'config',