Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: skia/skia_common.gypi

Issue 19477005: Improve Skia configuration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | skia/skia_library.gypi » ('j') | skia/skia_library.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/skia_common.gypi
===================================================================
--- skia/skia_common.gypi (revision 225491)
+++ skia/skia_common.gypi (working copy)
@@ -29,5 +29,31 @@
}],
],
+ 'variables': {
+ 'variables': { 'conditions': [
+ [ 'OS == "win"', {
+ 'skia_atomics_impl': 'win',
+ 'skia_mutex_impl': 'win',
+ }, {
bungeman-chromium 2013/09/26 22:42:46 djsollen: is there something that needs to go here
djsollen 2013/09/27 13:52:25 If the OS is android and use_system_skia is define
bungeman-skia 2013/09/27 17:59:13 Done.
+ 'skia_atomics_impl': 'sync',
+ 'skia_mutex_impl': 'pthread',
+ }],
+ ]},
+ 'skia_threading_defines': [
+ 'SK_ATOMICS_PLATFORM_H="third_party/skia/src/ports/SkAtomics_<(skia_atomics_impl).h"',
+ 'SK_MUTEX_PLATFORM_H="third_party/skia/src/ports/SkMutex_<(skia_mutex_impl).h"',
+ ],
+ },
+
+ 'defines': [
+ '<@(skia_threading_defines)',
+ ],
+
+ 'direct_dependent_settings': {
+ 'defines': [
+ '<@(skia_threading_defines)',
+ ],
+ },
+
'msvs_disabled_warnings': [4244, 4267, 4341, 4345, 4390, 4554, 4748, 4800],
}
« no previous file with comments | « no previous file | skia/skia_library.gypi » ('j') | skia/skia_library.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698