Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1947693003: BufferedDataSource now caches redirects for subsequent requests on Android (Closed)

Created:
4 years, 7 months ago by watk
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

BufferedDataSource now caches redirects for subsequent requests on Android Previously BDS would always make requests to the initial URL. So if the response was a redirect it would be followed on every subsequent request. Now we save the destination after redirects and use it for future requests. This will speed up seeking because we need to do fewer http requests, and is more robust because we can be more sure that we're requesting bytes from the same resource each time. See the bug for an example. This is Android only for now because Android has historically had this behavior. MultiBufferDataSource, which will replace BDS, also implements this logic, so all platforms will soon have it. BUG=606666 Review-Url: https://codereview.chromium.org/1924383002 Cr-Commit-Position: refs/heads/master@{#391121} (cherry picked from commit 7ca0b0cfb005a022f08346a778b4481b985078c1) Committed: https://chromium.googlesource.com/chromium/src/+/53716c01e23140c6889be4be1216245164f39728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M media/blink/buffered_data_source.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M media/blink/buffered_data_source_unittest.cc View 3 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
watk
4 years, 7 months ago (2016-05-03 20:05:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
53716c01e23140c6889be4be1216245164f39728.

Powered by Google App Engine
This is Rietveld 408576698