Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1947683002: Remove small window when function parameter types and names were reset to null (Closed)

Created:
4 years, 7 months ago by regis
Modified:
4 years, 7 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove small window when function parameter types and names were reset to null by background compiler, possibly crashing the main thread performing a function type test (fixes #26101). R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/1b36e9dbe6f0418e0264b4591a46d3e90858f4fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/vm/parser.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 7 months ago (2016-05-03 19:49:31 UTC) #2
hausner
LGTM
4 years, 7 months ago (2016-05-03 19:57:56 UTC) #3
regis
4 years, 7 months ago (2016-05-03 20:37:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b36e9dbe6f0418e0264b4591a46d3e90858f4fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698