Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/BUILD.gn

Issue 1947643002: Revert of Turn on assert_no_deps for blink in browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/password_manager/content/public/cpp/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 public_deps += [ "//chrome/service" ] 467 public_deps += [ "//chrome/service" ]
468 } 468 }
469 } 469 }
470 470
471 if (!is_component_build) { 471 if (!is_component_build) {
472 assert_no_deps = [ 472 assert_no_deps = [
473 # Blink and V8 should not be used in the browser process. In component 473 # Blink and V8 should not be used in the browser process. In component
474 # build this is OK because all of content is linked into one library. 474 # build this is OK because all of content is linked into one library.
475 # Note that the blink_headers target is OK, so we can't do a wildcard for 475 # Note that the blink_headers target is OK, so we can't do a wildcard for
476 # all blink targets. 476 # all blink targets.
477 "//third_party/WebKit/public:blink", 477 # TODO(brettw) bug 582206: Blink should not be linked into the browser
478 # process, and then we can enable this.
479 #"//third_party/WebKit/public:blink",
478 # TODO(brettw) bug 581766: V8 should not be linked into the browser 480 # TODO(brettw) bug 581766: V8 should not be linked into the browser
479 # process, and then we can enable this. 481 # process, and then we can enable this.
480 #"//v8/*", 482 #"//v8/*",
481 ] 483 ]
482 } 484 }
483 } 485 }
484 486
485 # GYP version: chromium_child_dependencies variable in chrome.gyp 487 # GYP version: chromium_child_dependencies variable in chrome.gyp
486 group("child_dependencies") { 488 group("child_dependencies") {
487 public_deps = [ 489 public_deps = [
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
1093 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1095 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1094 "//chrome/tools/build/linux/chrome-wrapper", 1096 "//chrome/tools/build/linux/chrome-wrapper",
1095 "//third_party/xdg-utils/scripts/xdg-mime", 1097 "//third_party/xdg-utils/scripts/xdg-mime",
1096 "//third_party/xdg-utils/scripts/xdg-settings", 1098 "//third_party/xdg-utils/scripts/xdg-settings",
1097 ] 1099 ]
1098 outputs = [ 1100 outputs = [
1099 "$root_out_dir/{{source_file_part}}", 1101 "$root_out_dir/{{source_file_part}}",
1100 ] 1102 ]
1101 } 1103 }
1102 } 1104 }
OLDNEW
« no previous file with comments | « no previous file | components/password_manager/content/public/cpp/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698