Disable custom Android linker when profiling is on (gn build).

Disable custom Android linker when profiling is on (gn build).

The gyp build disables the relocation packing linker in this case:
https://chromium.googlesource.com/chromium/src/+/2adf3ac9dd/build/java_apk.gypi#452

BUG=608414
Committed: https://crrev.com/c12f16c40c85acfe5bd1265c21a558f2b5a0de08
Cr-Commit-Position: refs/heads/master@{#391311}

[jbroman, 2016-05-03 17:21:47]

jbroman@chromium.org changed reviewers:
+ primiano@chromium.org, yfriedman@chromium.org

[jbroman, 2016-05-03 17:21:48]

This seems to fix symbolization of perf samples (from adb_profile_chrome and
friends).

R=primiano who suggested turning off the crazy linker
R=yfriedman for base/android/OWNERS

[Primiano Tucci (use gerrit), 2016-05-03 17:29:46]

non-owner LGTM.
Thanks for finding and fixing this.

[Yaron, 2016-05-03 18:18:36]

On 2016/05/03 17:29:46, Primiano Tucci wrote:
> non-owner LGTM.
> Thanks for finding and fixing this.

Andrew pointed out that there's some custom code in
third_party/android_platform/development/scripts/stack to handle relocation
packing. I wonder if that's correctly hooked up here or possibly broken in GN.
Regardless, I don't believe there's a harm to disable it in this case so lgtm

[Primiano Tucci (use gerrit), 2016-05-03 18:33:24]

On 2016/05/03 18:18:36, Yaron wrote:
> On 2016/05/03 17:29:46, Primiano Tucci wrote:
> > non-owner LGTM.
> > Thanks for finding and fixing this.
> 
> Andrew pointed out that there's some custom code in
> third_party/android_platform/development/scripts/stack to handle relocation
> packing. I wonder if that's correctly hooked up here or possibly broken in GN.
> Regardless, I don't believe there's a harm to disable it in this case so lgtm

Yeah I know that feels more trouble and more funky cross-dependencies to deal
with.
This feels to me more robust and just keeping up on-par with what gyp used to
do.

[jbroman, 2016-05-03 18:38:04]

On 2016/05/03 at 18:33:24, primiano wrote:
> On 2016/05/03 18:18:36, Yaron wrote:
> > On 2016/05/03 17:29:46, Primiano Tucci wrote:
> > > non-owner LGTM.
> > > Thanks for finding and fixing this.
> > 
> > Andrew pointed out that there's some custom code in
> > third_party/android_platform/development/scripts/stack to handle relocation
> > packing. I wonder if that's correctly hooked up here or possibly broken in
GN.
> > Regardless, I don't believe there's a harm to disable it in this case so
lgtm
> 
> Yeah I know that feels more trouble and more funky cross-dependencies to deal
with.
> This feels to me more robust and just keeping up on-par with what gyp used to
do.

It's not clear to me that anyone has gone through the effort of integrating that
with the profiling pipeline. If someone makes profiling work with relocation
packing, they're free to revert this patch then. ;)

[jbroman, 2016-05-03 18:38:07]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-05-03 18:39:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947633002/1

[commit-bot: I haz the power, 2016-05-03 18:44:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-03 18:46:41]

Description was changed from

==========
Disable custom Android linker when profiling is on (gn build).

The gyp build disables the relocation packing linker in this case:
https://chromium.googlesource.com/chromium/src/+/2adf3ac9dd/build/java_apk.gy...

BUG=608414
==========

to

==========
Disable custom Android linker when profiling is on (gn build).

The gyp build disables the relocation packing linker in this case:
https://chromium.googlesource.com/chromium/src/+/2adf3ac9dd/build/java_apk.gy...

BUG=608414

Committed: https://crrev.com/c12f16c40c85acfe5bd1265c21a558f2b5a0de08
Cr-Commit-Position: refs/heads/master@{#391311}
==========

[commit-bot: I haz the power, 2016-05-03 18:46:42]

Patchset 1 (id:??) landed as
https://crrev.com/c12f16c40c85acfe5bd1265c21a558f2b5a0de08
Cr-Commit-Position: refs/heads/master@{#391311}