Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

Issue 1947603002: Avoid clearing of Find In Page during BACK key press (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refined tests and fixed review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java
index 849c2221e7e6b2b35819fc6c33fd33dd05a4251c..1d5428430e7b7477bcbffe4934c0d135480833e9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java
@@ -23,6 +23,7 @@ import android.view.ActionMode;
import android.view.Gravity;
import android.view.KeyEvent;
import android.view.View;
+import android.view.View.OnKeyListener;
import android.widget.LinearLayout;
import android.widget.TextView;
@@ -89,11 +90,12 @@ public class FindToolbar extends LinearLayout
/** Subclasses EditText in order to intercept BACK key presses. */
@SuppressLint("Instantiatable")
- static class FindQuery extends VerticallyFixedEditText {
+ static class FindQuery extends VerticallyFixedEditText implements OnKeyListener {
private FindToolbar mFindToolbar;
public FindQuery(Context context, AttributeSet attrs) {
super(context, attrs);
+ setOnKeyListener(this);
}
void setFindToolbar(FindToolbar findToolbar) {
@@ -101,10 +103,9 @@ public class FindToolbar extends LinearLayout
}
@Override
- public boolean onKeyPreIme(int keyCode, KeyEvent event) {
+ public boolean onKey(View v, int keyCode, KeyEvent event) {
if (keyCode == KeyEvent.KEYCODE_BACK) {
- if (event.getAction() == KeyEvent.ACTION_DOWN
- && event.getRepeatCount() == 0) {
+ if (event.getAction() == KeyEvent.ACTION_DOWN && event.getRepeatCount() == 0) {
// Tell the framework to start tracking this event.
getKeyDispatcherState().startTracking(event, this);
return true;
@@ -116,7 +117,7 @@ public class FindToolbar extends LinearLayout
}
}
}
- return super.onKeyPreIme(keyCode, event);
+ return false;
}
@Override
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/widget/findinpage/FindTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698