Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 19476005: Use <(DEPTH) in derived_sources.gyp for saner paths (Closed)

Created:
7 years, 5 months ago by Nils Barth (inactive)
Modified:
7 years, 5 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Visibility:
Public.

Description

Use <(DEPTH) in derived_sources.gyp for saner paths Per abarth's suggestion, makes GYP more legible and robust: https://chromiumcodereview.appspot.com/15801003/#msg34 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/bindings/derived_sources.gyp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Hiyas, Quick fix to .gyp path per abarth's comment.
7 years, 5 months ago (2013-07-23 09:02:13 UTC) #1
haraken
LGTM
7 years, 5 months ago (2013-07-23 09:15:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/19476005/1
7 years, 5 months ago (2013-07-23 10:30:33 UTC) #3
commit-bot: I haz the power
Change committed as 154751
7 years, 5 months ago (2013-07-23 11:53:35 UTC) #4
abarth-chromium
7 years, 5 months ago (2013-07-23 17:08:26 UTC) #5
Message was sent while issue was closed.
Thanks!!!

Powered by Google App Engine
This is Rietveld 408576698