Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1947593002: Minor refactor of GrLayerHoister (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Minor refactor of GrLayerHoister The main point of this CL is to make sure using the rect bounds (rather than the underlying texture's bounds) is acceptable in GrLayerHoister::FilterLayer. This is split out of https://codereview.chromium.org/1943913002/ (Retract GrRenderTarget from GrLayerHoister) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1947593002 Committed: https://skia.googlesource.com/skia/+/b4511344b61bffc02219c1282610411529ddb7f8

Patch Set 1 #

Patch Set 2 : Minor refactor of GrLayerHoister #

Patch Set 3 : clean up #

Patch Set 4 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/gpu/GrLayerHoister.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
robertphillips
4 years, 7 months ago (2016-05-03 16:24:22 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947593002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947593002/60001
4 years, 7 months ago (2016-05-03 16:24:35 UTC) #8
bsalomon
lgtm
4 years, 7 months ago (2016-05-03 16:29:47 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 16:35:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947593002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947593002/60001
4 years, 7 months ago (2016-05-03 16:36:03 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 16:37:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/b4511344b61bffc02219c1282610411529ddb7f8

Powered by Google App Engine
This is Rietveld 408576698