Issue 1947573002: [DevTools] Hide the device frame when the viewport is too narrow to accomodate it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1947573002: [DevTools] Hide the device frame when the viewport is too narrow to accomodate it. (Closed)

Created:
4 years, 7 months ago by mmccoy

Modified:
4 years, 7 months ago

Reviewers:
paulirish, dgozman

CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[DevTools] Hide the device frame when the viewport is too narrow to accomodate it. BUG=605733, 607595

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css	View		2 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mmccoy

Temporary patch to hide device frames when the viewport is too narrow to respond correctly. ...

4 years, 7 months ago (2016-05-03 15:32:31 UTC) #2

paulirish

4 years, 7 months ago (2016-05-03 16:18:36 UTC) #3

Not sure about this. Some discussion over in
https://bugs.chromium.org/p/chromium/issues/detail?id=605733

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages