Second try at fixing location bar icon keyboard activation.

chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/icon_label_bubble_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/layout_constants.h"
 #include "chrome/browser/ui/views/location_bar/background_with_1_px_border.h"
 #include "ui/base/material_design/material_design_controller.h"
@@ skipping 110 matching lines @@
 
 bool IconLabelBubbleView::OnActivate() {
   return false;
 }
 
 gfx::Size IconLabelBubbleView::GetPreferredSize() const {
   // Height will be ignored by the LocationBarView.
   return GetSizeForLabelWidth(label_->GetPreferredSize().width());
 }
 
+bool IconLabelBubbleView::OnKeyPressed(const ui::KeyEvent& event) {
+  if (event.key_code() == ui::VKEY_RETURN)
+    return OnActivate();
+  return false;

[Peter Kasting, 2016/05/04 02:21:00]

BubbleIconView::OnKeyPressed() returned true for space, but this returns false. 
Seems like one of these isn't right.

[Evan Stade, 2016/05/04 02:45:52]

yea, this one isn't right; it should show a ripple and count the accelerator as
handled. I filed crbug.com/608976 for that.

+}
+
 bool IconLabelBubbleView::OnKeyReleased(const ui::KeyEvent& event) {
-  if (event.key_code() != ui::VKEY_RETURN && event.key_code() != ui::VKEY_SPACE)
-    return false;
-  return OnActivate();
+  if (event.key_code() == ui::VKEY_SPACE)
+    return OnActivate();
+  return false;
 }
 
 void IconLabelBubbleView::Layout() {
   // Compute the image bounds.  In non-MD, the leading padding depends on
   // whether this is an extension icon, since extension icons and
   // Chrome-provided icons are different sizes.  In MD, these sizes are the
   // same, so it's not necessary to handle the two types differently.
   const bool icon_has_enough_padding =
       !is_extension_icon_ || ui::MaterialDesignController::IsModeMaterial();
   int image_x = GetOuterPadding(icon_has_enough_padding);
@@ skipping 148 matching lines @@
 void IconLabelBubbleView::OnPaint(gfx::Canvas* canvas) {
   if (!ShouldShowBackground())
     return;
   if (background_painter_) {
     views::Painter::PaintPainterAt(canvas, background_painter_.get(),
                                    GetContentsBounds());
   }
   if (background())
     background()->Paint(canvas, this);
 }