Material WebUI: create shared icon file.

Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

To keep this CL small we only update Settings and Downloads
to use these; a follow-up will update other WebUI. Further
follow-ups will be created by app owners to create their own
per-app shared icon files.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true # crisper.js

Committed: https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1
Cr-Commit-Position: refs/heads/master@{#391627}

[michaelpg, 2016-05-03 14:28:20]

Description was changed from

==========
Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
==========

to

==========
Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-03 14:30:58]

Description was changed from

==========
Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

To keep this CL small we only update Settings and Downloads
to use these; a follow-up will update other WebUI. Further
follow-ups will be created by app owners to create their own
per-app shared icon files.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-03 14:31:24]

Description was changed from

==========
Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

To keep this CL small we only update Settings and Downloads
to use these; a follow-up will update other WebUI. Further
follow-ups will be created by app owners to create their own
per-app shared icon files.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

To keep this CL small we only update Settings and Downloads
to use these; a follow-up will update other WebUI. Further
follow-ups will be created by app owners to create their own
per-app shared icon files.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true # crisper.js
==========

[michaelpg, 2016-05-03 14:52:27]

PTAL. This partially replaces https://codereview.chromium.org/1928243002/

[Dan Beam, 2016-05-03 23:59:09]

what denotes a commonly used icon? more than 1 UI?

[michaelpg, 2016-05-04 02:03:15]

On 2016/05/03 23:59:09, Dan Beam wrote:
> what denotes a commonly used icon? more than 1 UI?

it's a judgment call, I don't want to make a rule besides that icons
in cr_elements should be in cr_icons.

Ultimately it doesn't matter a ton: having per-application iconsets
and cr_icons is so much less wasteful than importing (and vulcanizing)
all 900 that the difference between duplicating or consolidating
individual icons is not a big deal by comparison.

[Dan Beam, 2016-05-04 05:04:13]

lgtm but I'm still a little hazy here: so are we attempting to remove iron-icons
from bower.json eventually?

[Dan Beam, 2016-05-04 05:04:16]

lgtm but I'm still a little hazy here: so are we attempting to remove iron-icons
from bower.json eventually?

[Dan Beam, 2016-05-04 05:05:07]

On 2016/05/04 05:04:16, Dan Beam wrote:
> lgtm but I'm still a little hazy here: so are we attempting to remove
iron-icons
> from bower.json eventually?

nevermind, I read the CL desc

[michaelpg, 2016-05-04 19:45:37]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-05-04 19:45:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1947533002/#ps120001
(title: "rebase fix")

[commit-bot: I haz the power, 2016-05-04 19:46:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947533002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947533002/120001

[commit-bot: I haz the power, 2016-05-04 20:41:10]

Description was changed from

==========
Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

To keep this CL small we only update Settings and Downloads
to use these; a follow-up will update other WebUI. Further
follow-ups will be created by app owners to create their own
per-app shared icon files.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true # crisper.js
==========

to

==========
Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

To keep this CL small we only update Settings and Downloads
to use these; a follow-up will update other WebUI. Further
follow-ups will be created by app owners to create their own
per-app shared icon files.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true # crisper.js
==========

[commit-bot: I haz the power, 2016-05-04 20:41:12]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-05-04 20:43:01]

Description was changed from

==========
Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

To keep this CL small we only update Settings and Downloads
to use these; a follow-up will update other WebUI. Further
follow-ups will be created by app owners to create their own
per-app shared icon files.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true # crisper.js
==========

to

==========
Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

To keep this CL small we only update Settings and Downloads
to use these; a follow-up will update other WebUI. Further
follow-ups will be created by app owners to create their own
per-app shared icon files.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true # crisper.js

Committed: https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1
Cr-Commit-Position: refs/heads/master@{#391627}
==========

[commit-bot: I haz the power, 2016-05-04 20:43:02]

Patchset 7 (id:??) landed as
https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1
Cr-Commit-Position: refs/heads/master@{#391627}