Validate input dates in my_reviews.py.

Validate input dates in my_reviews.py.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=256292

[Lei Zhang, 2014-03-11 19:16:40]

Using 2014-02-30 as a date should not fail silently

[M-A Ruel, 2014-03-11 19:34:05]

https://codereview.chromium.org/194753007/diff/1/my_reviews.py
File my_reviews.py (right):

https://codereview.chromium.org/194753007/diff/1/my_reviews.py#newcode351
my_reviews.py:351: print 'Error: %s: %s - %s' % (e, options.begin, options.end)
Use parser.error() instead. No need to return, since parser.error() exits the
process.

[Lei Zhang, 2014-03-11 19:42:21]

https://codereview.chromium.org/194753007/diff/1/my_reviews.py
File my_reviews.py (right):

https://codereview.chromium.org/194753007/diff/1/my_reviews.py#newcode351
my_reviews.py:351: print 'Error: %s: %s - %s' % (e, options.begin, options.end)
On 2014/03/11 19:34:06, M-A Ruel wrote:
> Use parser.error() instead. No need to return, since parser.error() exits the
> process.

Done.

[M-A Ruel, 2014-03-11 19:44:37]

lgtm

https://codereview.chromium.org/194753007/diff/20001/my_reviews.py
File my_reviews.py (right):

https://codereview.chromium.org/194753007/diff/20001/my_reviews.py#newcode350
my_reviews.py:350: except ValueError, e:
Oh I had forgot; use the new form:
except ValueError as e:

[Lei Zhang, 2014-03-11 20:01:47]

https://codereview.chromium.org/194753007/diff/20001/my_reviews.py
File my_reviews.py (right):

https://codereview.chromium.org/194753007/diff/20001/my_reviews.py#newcode350
my_reviews.py:350: except ValueError, e:
On 2014/03/11 19:44:37, M-A Ruel wrote:
> Oh I had forgot; use the new form:
> except ValueError as e:

Done.

[Lei Zhang, 2014-03-11 20:01:50]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-03-11 20:01:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/194753007/40001

[commit-bot: I haz the power, 2014-03-11 20:04:25]

Change committed as 256292