Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 194753005: Remove unnecassary parameter "sampleRate" for loadAudioResource(). (Closed)

Created:
6 years, 9 months ago by KhNo
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unnecassary parameter "sampleRate" for loadAudioResource(). Parameter "sampleRate" is not required for loadAudioResource(). There is FIXME in AudioBus.cpp in blink FIXME: the sampleRate parameter is ignored. It should be removed from the API. It will be consist of 3 steps. 1. Removing "sampleRate" in chrome which is called by blink. (included deprecated method) https://codereview.chromium.org/195043002/ 2. Removing "sampleRate" in blink. https://codereview.chromium.org/194753005/ 3. Removing deprecated method from #1 https://codereview.chromium.org/199573004/ BUG=351284 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M Source/platform/audio/AudioBus.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M public/platform/Platform.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
KhNo
Please review the patch set. This patch is related with https://codereview.chromium.org/195043002/
6 years, 9 months ago (2014-03-11 13:29:00 UTC) #1
KhNo
jamesr@chromium.org: Please review changes in
6 years, 9 months ago (2014-03-11 13:29:28 UTC) #2
jamesr
This looks like a patch for Raymond. I'll be happy to rubber-stamp once he's happy.
6 years, 9 months ago (2014-03-11 21:59:21 UTC) #3
Raymond Toy
On 2014/03/11 21:59:21, jamesr wrote: > This looks like a patch for Raymond. I'll be ...
6 years, 9 months ago (2014-03-13 02:13:45 UTC) #4
KhNo
On 2014/03/13 02:13:45, Raymond Toy wrote: > On 2014/03/11 21:59:21, jamesr wrote: > > This ...
6 years, 9 months ago (2014-03-13 17:08:41 UTC) #5
jamesr
lgtm
6 years, 9 months ago (2014-03-13 19:11:14 UTC) #6
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 9 months ago (2014-03-14 00:14:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/194753005/1
6 years, 9 months ago (2014-03-14 00:14:18 UTC) #8
KhNo
On 2014/03/13 19:11:14, jamesr wrote: > lgtm Thank you. :)
6 years, 9 months ago (2014-03-14 00:14:53 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 01:10:19 UTC) #10
Message was sent while issue was closed.
Change committed as 169188

Powered by Google App Engine
This is Rietveld 408576698