Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Unified Diff: test/cctest/test-assembler-a64.cc

Issue 194753002: A64: Fix Fmov with signalling NaN literals. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/a64/macro-assembler-a64-inl.h ('k') | test/cctest/test-disasm-a64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-assembler-a64.cc
diff --git a/test/cctest/test-assembler-a64.cc b/test/cctest/test-assembler-a64.cc
index ac200bca15332e2a6bd1704cfa0cc1c9a9ae61a5..017b55953f7c84423e4a5db99fcc621ebaef36f8 100644
--- a/test/cctest/test-assembler-a64.cc
+++ b/test/cctest/test-assembler-a64.cc
@@ -5473,14 +5473,8 @@ static void FminFmaxFloatHelper(float n, float m, float min, float max,
SETUP();
START();
- // TODO(all): Signalling NaNs are sometimes converted by the C compiler to
- // quiet NaNs on implicit casts from float to double. Here, we move the raw
- // bits into a W register first, so we get the correct value. Fix Fmov so this
- // additional step is no longer needed.
- __ Mov(w0, float_to_rawbits(n));
- __ Fmov(s0, w0);
- __ Mov(w0, float_to_rawbits(m));
- __ Fmov(s1, w0);
+ __ Fmov(s0, n);
+ __ Fmov(s1, m);
__ Fmin(s28, s0, s1);
__ Fmax(s29, s0, s1);
__ Fminnm(s30, s0, s1);
« no previous file with comments | « src/a64/macro-assembler-a64-inl.h ('k') | test/cctest/test-disasm-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698