Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1947523002: Let landmines print something when run as part of `gclient sync`. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let landmines print something when run as part of `gclient sync`. (Maybe only needed on Windows.) Landmines take unusably long when they run on Windows, and if this prints the diff I can ctrl-c, manually apply that diff to .landmines, and then runhooks again :-/ BUG=none Committed: https://crrev.com/d7d6455c81e282c92daff0f396ea55fbc5d22235 Cr-Commit-Position: refs/heads/master@{#391291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/landmines.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Nico
The motivation for this change is questionable, but it seems like a good change independent ...
4 years, 7 months ago (2016-05-03 14:26:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947523002/1
4 years, 7 months ago (2016-05-03 14:35:11 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 15:17:29 UTC) #6
scottmg
Why does it take a long time? Isn't this just diffing two tiny text files? ...
4 years, 7 months ago (2016-05-03 17:17:38 UTC) #7
Nico
The diffing is fast, but the actual clobbering is very slow (I thought "I'll just ...
4 years, 7 months ago (2016-05-03 17:33:01 UTC) #8
scottmg
On 2016/05/03 17:33:01, Nico wrote: > The diffing is fast, but the actual clobbering is ...
4 years, 7 months ago (2016-05-03 17:34:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947523002/1
4 years, 7 months ago (2016-05-03 17:55:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 18:00:18 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:02:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7d6455c81e282c92daff0f396ea55fbc5d22235
Cr-Commit-Position: refs/heads/master@{#391291}

Powered by Google App Engine
This is Rietveld 408576698